Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2537743002: Add HTTP User Agent flag for cipd. (Closed)

Created:
4 years ago by iannucci
Modified:
4 years ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add HTTP User Agent flag for cipd. #

Total comments: 1

Patch Set 3 : Clarify help text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M cipd/client/cmd/cipd/main.go View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
iannucci
4 years ago (2016-11-29 09:35:50 UTC) #1
dnj
lgtm w/ nit https://codereview.chromium.org/2537743002/diff/20001/cipd/client/cmd/cipd/main.go File cipd/client/cmd/cipd/main.go (right): https://codereview.chromium.org/2537743002/diff/20001/cipd/client/cmd/cipd/main.go#newcode243 cipd/client/cmd/cipd/main.go:243: f.StringVar(&opts.userAgent, "http-user-agent", "", "User Agent string ...
4 years ago (2016-11-29 16:42:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537743002/40001
4 years ago (2016-11-29 18:00:45 UTC) #5
iannucci
On 2016/11/29 16:42:47, dnj wrote: > lgtm w/ nit > > https://codereview.chromium.org/2537743002/diff/20001/cipd/client/cmd/cipd/main.go > File cipd/client/cmd/cipd/main.go ...
4 years ago (2016-11-29 18:00:53 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-29 18:06:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/06da8fd9f80dffc72b5fa66c28226d237c285044

Powered by Google App Engine
This is Rietveld 408576698