Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253773004: Remove dependency of views on angle (Closed)

Created:
6 years, 7 months ago by scroggo
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove dependency of views on angle Just like with http://code.google.com/p/skia/source/detail?r=13618, listing angle.gyp as a dependency when in the Android tree (i.e. w/o third_party/externals) causes gyp_to_android.py to fail. (See http://108.170.220.27:10115/builders/Housekeeper-PerCommit-AndroidRoll/builds/229/steps/Merge/logs/stdio for example failure.) Fortunately, views (and views_animated) has no need to depend directly on angle. TBR=bsalomon@google.com BUG=skia:2447 Committed: http://code.google.com/p/skia/source/detail?r=14426

Patch Set 1 #

Patch Set 2 : Remove views' dependency on angle. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M gyp/views.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M gyp/views_animated.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
6 years, 7 months ago (2014-04-28 19:31:01 UTC) #1
scroggo
6 years, 7 months ago (2014-04-28 20:31:18 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 7 months ago (2014-04-29 00:30:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/253773004/20001
6 years, 7 months ago (2014-04-29 00:31:17 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 00:38:41 UTC) #5
Message was sent while issue was closed. 
Change committed as 14426

Powered by Google App Engine
This is Rietveld 408576698