device/vr/vr_device_manager.h - Issue 2537723002: Refine VRDevice Class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/vr_device_manager.h

Issue 2537723002: Refine VRDevice Class (Closed)

Patch Set: address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/vr_device_manager.h

diff --git a/device/vr/vr_device_manager.h b/device/vr/vr_device_manager.h

index b53d546944de68f67396e39e13a37526fcf750e7..6d3722bb364aa731b8437e3cd93c301f0469bb01 100644

--- a/device/vr/vr_device_manager.h

+++ b/device/vr/vr_device_manager.h

@@ -72,8 +72,8 @@ class VRDeviceManager {

bool vr_initialized_;

- using ServiceList = std::vector<VRServiceImpl*>;

- ServiceList services_;

+ using ServiceSet = std::set<VRServiceImpl*>;

mthiesse 2016/11/30 13:59:04 nit: type alias is also pretty useless here, might

+ ServiceSet services_;

// For testing. If true will not delete self when consumer count reaches 0.

bool keep_alive_;