chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc - Issue 2537713002: Add support for transparent/translucent pixels in the user image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

Issue 2537713002: Add support for transparent/translucent pixels in the user image (Closed)

Patch Set: rebased Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/users/avatar/user_image_manager_test_util.cc ('k') | chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

index 288b16dc2ec0c6acadd32bf5e81279cbd4bdf952..f6056dd50c513b93135a758eb0f38802b1c9e033 100644

--- a/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

@@ -353,7 +353,8 @@ void ChangePictureOptionsHandler::HandleSelectImage(

// Previous image (from camera or manually uploaded) re-selected.

DCHECK(!previous_image_.isNull());

user_image_manager->SaveUserImage(

- user_manager::UserImage::CreateAndEncode(previous_image_));

+ user_manager::UserImage::CreateAndEncode(

+ previous_image_, user_manager::UserImage::FORMAT_JPEG));

UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",

default_user_image::kHistogramImageOld,

@@ -417,7 +418,8 @@ void ChangePictureOptionsHandler::SetImageFromCamera(

const gfx::ImageSkia& photo) {

ChromeUserManager::Get()

->GetUserImageManager(GetUser()->GetAccountId())

- ->SaveUserImage(user_manager::UserImage::CreateAndEncode(photo));

+ ->SaveUserImage(user_manager::UserImage::CreateAndEncode(

+ photo, user_manager::UserImage::FORMAT_JPEG));

UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",

default_user_image::kHistogramImageFromCamera,

default_user_image::kHistogramImagesCount);