Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 2537673002: Update linux_me2me_host.py to exit when Ctrl-C is pressed. (Closed)

Created:
4 years ago by Sergey Ulanov
Modified:
4 years ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update linux_me2me_host.py to exit when Ctrl-C is pressed. Previously when Ctrl-C is pressed the script would print a message that says it was interrupted, but wouldn't actually quit. Added explicit exit(1) call in sigint_handler() to ensure it quits as expected. Committed: https://crrev.com/ab6dea0afad643b203d4cfd2f4c660cdae53ee01 Cr-Commit-Position: refs/heads/master@{#435063}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M remoting/host/linux/linux_me2me_host.py View 1 2 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sergey Ulanov
4 years ago (2016-11-29 00:41:53 UTC) #2
Lambros
https://codereview.chromium.org/2537673002/diff/1/remoting/host/linux/linux_me2me_host.py File remoting/host/linux/linux_me2me_host.py (left): https://codereview.chromium.org/2537673002/diff/1/remoting/host/linux/linux_me2me_host.py#oldcode903 remoting/host/linux/linux_me2me_host.py:903: print("Log file: %s" % os.environ[LOG_FILE_ENV_VAR], file=sys.stderr) Did you intend ...
4 years ago (2016-11-29 18:47:58 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/2537673002/diff/1/remoting/host/linux/linux_me2me_host.py File remoting/host/linux/linux_me2me_host.py (left): https://codereview.chromium.org/2537673002/diff/1/remoting/host/linux/linux_me2me_host.py#oldcode903 remoting/host/linux/linux_me2me_host.py:903: print("Log file: %s" % os.environ[LOG_FILE_ENV_VAR], file=sys.stderr) On 2016/11/29 18:47:58, ...
4 years ago (2016-11-29 19:40:23 UTC) #4
Lambros
lgtm
4 years ago (2016-11-29 19:44:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537673002/20001
4 years ago (2016-11-29 19:44:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 19:56:40 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-29 20:01:54 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab6dea0afad643b203d4cfd2f4c660cdae53ee01
Cr-Commit-Position: refs/heads/master@{#435063}

Powered by Google App Engine
This is Rietveld 408576698