third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2537653002: Invalidate previousLocationInBacking in LayoutObject::clearPreviousVisualRects()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2537653002: Invalidate previousLocationInBacking in LayoutObject::clearPreviousVisualRects() (Closed)

Patch Set: setMayNeedPaintInvalidationSubtree Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index e1d3ca391ef088bf79da46d2110b12e693710a77..2049367d76af354817202b78d02a37dc94f97772 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -1259,7 +1259,11 @@ void LayoutObject::adjustPreviousPaintInvalidationForScrollIfNeeded(

void LayoutObject::clearPreviousVisualRects() {

setPreviousVisualRect(LayoutRect());

- // After clearing ("invalidating" the visual rects, mark this object as

+ ObjectPaintInvalidator(*this).setPreviousLocationInBacking(LayoutPoint());

+ // Ensure check paint invalidation of subtree that would be triggered by

+ // location change if we had valid previous location.

+ setMayNeedPaintInvalidationSubtree();

+ // After clearing ("invalidating") the visual rects, mark this object as

// needing to re-compute them.

setShouldDoFullPaintInvalidation();

}