third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2537653002: Invalidate previousLocationInBacking in LayoutObject::clearPreviousVisualRects()

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2537653002: Invalidate previousLocationInBacking in LayoutObject::clearPreviousVisualRects() (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index e1d3ca391ef088bf79da46d2110b12e693710a77..e1d5d1d10fd09a5624c45168c3f31844e75db7ff 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -1259,6 +1259,10 @@ void LayoutObject::adjustPreviousPaintInvalidationForScrollIfNeeded(

void LayoutObject::clearPreviousVisualRects() {

setPreviousVisualRect(LayoutRect());

+ // Also invalidate the previous location by setting it to a special value so

+ // that it won't match any meaningful location.

+ ObjectPaintInvalidator(*this).setPreviousLocationInBacking(

+ LayoutPoint(LayoutUnit::nearlyMin(), LayoutUnit::nearlyMin()));

// After clearing ("invalidating" the visual rects, mark this object as

chrishtr 2016/11/29 00:57:59 Noticed a typo here with mismatched parens. Might

Xianzhu 2016/11/29 01:43:27 Done.

// needing to re-compute them.

setShouldDoFullPaintInvalidation();

chrishtr 2016/11/29 00:57:59 This call here on line 1268 should cause full pain

Xianzhu 2016/11/29 01:43:27 We'll get the location recomputed, but may miss se