Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2537643005: Refactoring a code pattern in previews_experiments.cc (Closed)

Created:
4 years ago by RyanSturm
Modified:
4 years ago
Reviewers:
tbansal1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring a code pattern in previews_experiments.cc This changes a code pattern in previews params to be a little more readable and in some cases more efficient in terms of binary size. BUG=669683 Committed: https://crrev.com/de09bb7918768dcb4d73b1183c3ab7c1526696bb Cr-Commit-Position: refs/heads/master@{#435253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -27 lines) Patch
M components/previews/core/previews_experiments.cc View 1 chunk +18 lines, -27 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
RyanSturm
tbansal: PTAL This is based on codereview feedback from https://codereview.chromium.org/2537563002/ It is strictly a code ...
4 years ago (2016-11-29 23:02:51 UTC) #4
tbansal1
lgtm
4 years ago (2016-11-29 23:08:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537643005/1
4 years ago (2016-11-30 14:13:16 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 14:17:06 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-30 14:18:28 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de09bb7918768dcb4d73b1183c3ab7c1526696bb
Cr-Commit-Position: refs/heads/master@{#435253}

Powered by Google App Engine
This is Rietveld 408576698