components/policy/core/common/remote_commands/remote_commands_service_unittest.cc - Issue 2537643003: Drop verification_key_hash from CloudPolicyClient constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/remote_commands/remote_commands_service_unittest.cc

Issue 2537643003: Drop verification_key_hash from CloudPolicyClient constructor (Closed)

Patch Set: Fix CrOS compilation Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/cloud/user_cloud_policy_manager.cc ('K') | « components/policy/core/common/cloud/user_cloud_policy_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/remote_commands/remote_commands_service_unittest.cc

diff --git a/components/policy/core/common/remote_commands/remote_commands_service_unittest.cc b/components/policy/core/common/remote_commands/remote_commands_service_unittest.cc

index 97fdc95fada2661b790fbbc8abd772ed9fa10200..8ad42ce62a692b0d6d95f563c1f5eab411947580 100644

--- a/components/policy/core/common/remote_commands/remote_commands_service_unittest.cc

+++ b/components/policy/core/common/remote_commands/remote_commands_service_unittest.cc

@@ -84,7 +84,6 @@ class TestingCloudPolicyClientForRemoteCommands : public CloudPolicyClient {

TestingRemoteCommandsServer* server)

: CloudPolicyClient(std::string(), /* machine_id */

std::string(), /* machine_model */

- std::string(), /* verification_key_hash */

nullptr,

emaxx 2016/11/29 14:24:58 nit: IMHO, same as above (regarding commenting the

Thiemo Nagel 2016/11/29 15:16:38 Done.

nullptr,

nullptr /* signing_service */),

« components/policy/core/common/cloud/user_cloud_policy_manager.cc ('K') | « components/policy/core/common/cloud/user_cloud_policy_manager.cc ('k') | no next file » | no next file with comments »