chrome/browser/chromeos/policy/device_local_account_policy_service.cc - Issue 2537643003: Drop verification_key_hash from CloudPolicyClient constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_local_account_policy_service.cc

Issue 2537643003: Drop verification_key_hash from CloudPolicyClient constructor (Closed)

Patch Set: Fix CrOS compilation Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc ('k') | chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc » ('j') | components/policy/core/common/cloud/cloud_policy_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_local_account_policy_service.cc

diff --git a/chrome/browser/chromeos/policy/device_local_account_policy_service.cc b/chrome/browser/chromeos/policy/device_local_account_policy_service.cc

index 482544ca81909aea7e329892315b54f20541e954..e6a73bcbaa29dec474bafc899e9f80b454efc873 100644

--- a/chrome/browser/chromeos/policy/device_local_account_policy_service.cc

+++ b/chrome/browser/chromeos/policy/device_local_account_policy_service.cc

@@ -32,7 +32,6 @@

#include "chromeos/settings/cros_settings_provider.h"

#include "components/policy/core/browser/browser_policy_connector.h"

#include "components/policy/core/common/cloud/cloud_policy_client.h"

-#include "components/policy/core/common/cloud/cloud_policy_constants.h"

emaxx 2016/11/29 14:24:58 nit: I think it's still necessary, e.g. for dm_pro

Thiemo Nagel 2016/11/29 15:16:38 Done.

#include "components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h"

#include "components/policy/core/common/cloud/device_management_service.h"

#include "components/policy/core/common/cloud/resource_cache.h"

@@ -66,9 +65,8 @@ std::unique_ptr<CloudPolicyClient> CreateClient(

}

std::unique_ptr<CloudPolicyClient> client(new CloudPolicyClient(

- std::string(), std::string(), kPolicyVerificationKeyHash,

- device_management_service, system_request_context,

- nullptr /* signing_service */));

+ std::string(), std::string(), device_management_service,

+ system_request_context, nullptr /* signing_service */));

client->SetupRegistration(policy_data->request_token(),

policy_data->device_id());

return client;