Drop verification_key_hash from CloudPolicyClient constructor

Drop verification_key_hash from CloudPolicyClient constructor

kPolicyVerificationKeyHash is the only possible value anyways (outside
of tests).

BUG=none

Committed: https://crrev.com/33858433ab2b911c55d6fbd94889f54ae0a64426
Cr-Commit-Position: refs/heads/master@{#435006}

[Thiemo Nagel, 2016-11-29 11:56:22]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 11:56:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2016-11-29 12:03:40]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 12:03:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 13:10:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 13:10:58]

Dry run: This issue passed the CQ dry run.

[Thiemo Nagel, 2016-11-29 13:16:01]

tnagel@chromium.org changed reviewers:
+ emaxx@chromium.org

[Thiemo Nagel, 2016-11-29 13:16:02]

Hi Maksim,

could you please take a look at this small refactoring?

Thank you,
Thiemo

[emaxx, 2016-11-29 14:24:58]

lgtm

https://codereview.chromium.org/2537643003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_local_account_policy_service.cc
(left):

https://codereview.chromium.org/2537643003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_local_account_policy_service.cc:35:
#include "components/policy/core/common/cloud/cloud_policy_constants.h"
nit: I think it's still necessary, e.g. for
dm_protocol::kChromeExtensionPolicyType used below.

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
File components/policy/core/common/cloud/cloud_policy_client.cc (right):

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
components/policy/core/common/cloud/cloud_policy_client.cc:15: #include
"components/policy/core/common/cloud/cloud_policy_constants.h"
nit: This is already included in the header file.

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
File components/policy/core/common/cloud/mock_cloud_policy_client.cc (right):

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
components/policy/core/common/cloud/mock_cloud_policy_client.cc:17: :
CloudPolicyClient(std::string(),
nit: I understand that this is the old and testing-only code, but I think it
would be nice to have comments here containing the names of the arguments.

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
File components/policy/core/common/cloud/user_cloud_policy_manager.cc (left):

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
components/policy/core/common/cloud/user_cloud_policy_manager.cc:14: #include
"components/policy/core/common/cloud/cloud_policy_constants.h"
nit: Same as above, see e.g. the dm_protocol::kChromeUserPolicyType reference in
this file.

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
File
components/policy/core/common/remote_commands/remote_commands_service_unittest.cc
(right):

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
components/policy/core/common/remote_commands/remote_commands_service_unittest.cc:87:
nullptr,
nit: IMHO, same as above (regarding commenting the arg names).

[Thiemo Nagel, 2016-11-29 15:14:10]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 15:14:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2016-11-29 15:15:38]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 15:15:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2016-11-29 15:16:38]

Thank you, I've addressed your comments.  Do you want to take another look?

https://codereview.chromium.org/2537643003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_local_account_policy_service.cc
(left):

https://codereview.chromium.org/2537643003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_local_account_policy_service.cc:35:
#include "components/policy/core/common/cloud/cloud_policy_constants.h"
On 2016/11/29 14:24:58, emaxx wrote:
> nit: I think it's still necessary, e.g. for
> dm_protocol::kChromeExtensionPolicyType used below.

Done.

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
File components/policy/core/common/cloud/cloud_policy_client.cc (right):

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
components/policy/core/common/cloud/cloud_policy_client.cc:15: #include
"components/policy/core/common/cloud/cloud_policy_constants.h"
On 2016/11/29 14:24:58, emaxx wrote:
> nit: This is already included in the header file.

Done.

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
File components/policy/core/common/cloud/mock_cloud_policy_client.cc (right):

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
components/policy/core/common/cloud/mock_cloud_policy_client.cc:17: :
CloudPolicyClient(std::string(),
On 2016/11/29 14:24:58, emaxx wrote:
> nit: I understand that this is the old and testing-only code, but I think it
> would be nice to have comments here containing the names of the arguments.

Done.

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
File components/policy/core/common/cloud/user_cloud_policy_manager.cc (left):

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
components/policy/core/common/cloud/user_cloud_policy_manager.cc:14: #include
"components/policy/core/common/cloud/cloud_policy_constants.h"
On 2016/11/29 14:24:58, emaxx wrote:
> nit: Same as above, see e.g. the dm_protocol::kChromeUserPolicyType reference
in
> this file.

Done.

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
File
components/policy/core/common/remote_commands/remote_commands_service_unittest.cc
(right):

https://codereview.chromium.org/2537643003/diff/20001/components/policy/core/...
components/policy/core/common/remote_commands/remote_commands_service_unittest.cc:87:
nullptr,
On 2016/11/29 14:24:58, emaxx wrote:
> nit: IMHO, same as above (regarding commenting the arg names).

Done.

[emaxx, 2016-11-29 15:40:55]

nope, still LGTM!

[commit-bot: I haz the power, 2016-11-29 16:06:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 16:06:15]

Dry run: This issue passed the CQ dry run.

[Thiemo Nagel, 2016-11-29 16:12:48]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2016-11-29 16:13:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 16:17:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480435968280130,
"parent_rev": "653068de6695cac26d3dbbdf68dc32b89b41cbcb", "commit_rev":
"c507b0dd1715d66bab270db7f436cb9bb3106054"}

[commit-bot: I haz the power, 2016-11-29 16:17:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-29 16:20:27]

Description was changed from

==========
Drop verification_key_hash from CloudPolicyClient constructor

kPolicyVerificationKeyHash is the only possible value anyways (outside
of tests).

BUG=none
==========

to

==========
Drop verification_key_hash from CloudPolicyClient constructor

kPolicyVerificationKeyHash is the only possible value anyways (outside
of tests).

BUG=none

Committed: https://crrev.com/33858433ab2b911c55d6fbd94889f54ae0a64426
Cr-Commit-Position: refs/heads/master@{#435006}
==========

[commit-bot: I haz the power, 2016-11-29 16:20:28]

Patchset 4 (id:??) landed as
https://crrev.com/33858433ab2b911c55d6fbd94889f54ae0a64426
Cr-Commit-Position: refs/heads/master@{#435006}