Add VR instrumentation tests to FYI bot

Add VR instrumentation tests to FYI bot

Adds the chrome_public_test_apk instrumentation tests to the Android VR FYI
builder and limits it to VR-related tests using the functionality added in
https://bugs.chromium.org/p/chromium/issues/detail?id=658342

BUG=

Committed: https://crrev.com/d10df401216bf72f170da66d268e17c772e2972e
Cr-Commit-Position: refs/heads/master@{#435039}

[bsheedy, 2016-11-28 22:45:22]

bsheedy@chromium.org changed reviewers:
+ nick@chromium.org

[bsheedy, 2016-11-28 22:45:23]

PTAL, shouldn't affect anything except an FYI builder only a few people care
about.

[ncarter (slow), 2016-11-28 23:56:23]

I'm not familiar enough with this .json file to offer much of a review.

https://codereview.chromium.org/2537633002/diff/1/testing/buildbot/chromium.f...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/2537633002/diff/1/testing/buildbot/chromium.f...
testing/buildbot/chromium.fyi.json:901: "--test-filter",
Is this supposed to be gtest_filter ?

The only reference to 'test-filter' I see in the code is
build/android/test_runner.py

[bsheedy, 2016-11-29 00:11:54]

https://codereview.chromium.org/2537633002/diff/1/testing/buildbot/chromium.f...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/2537633002/diff/1/testing/buildbot/chromium.f...
testing/buildbot/chromium.fyi.json:901: "--test-filter",
On 2016/11/28 23:56:23, ncarter wrote:
> Is this supposed to be gtest_filter ?
> 
> The only reference to 'test-filter' I see in the code is
> build/android/test_runner.py

It's meant to be passed directly to the generated binary file that runs the
instrumentation test, which I believe is based off build/android/test_runner.py.
In this case, it's run_chrome_public_test_apk (see
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Te...).

When run locally, you can call "run_chrome_public_test_apk --test-filter
VrShellTest#*" to only run the tests in VrShellTest.java, and the way args
support was added to tests under instrumentation_tests, ["--test-filter",
"VrShellTest#*"] should result in "run_chrome_public_test_apk --test-filter
VrShellTest#*" being called on the builder. See
https://chromium.googlesource.com/chromium/tools/build.git/+/ec0cd54e792581bb...
for the CL where args support was added to instrumentation_tests.

[ncarter (slow), 2016-11-29 06:27:44]

lgtm

[bsheedy, 2016-11-29 17:37:23]

The CQ bit was checked by bsheedy@chromium.org

[commit-bot: I haz the power, 2016-11-29 17:37:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 18:41:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480441043145050, "parent_rev":
"42ac4f2079333566eeef7c263d1af6609c78f9d2", "commit_rev":
"26f0b00fc813bd83bd05009252a85528d840471a"}

[commit-bot: I haz the power, 2016-11-29 18:41:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-29 18:46:49]

Description was changed from

==========
Add VR instrumentation tests to FYI bot

Adds the chrome_public_test_apk instrumentation tests to the Android VR FYI
builder and limits it to VR-related tests using the functionality added in
https://bugs.chromium.org/p/chromium/issues/detail?id=658342

BUG=
==========

to

==========
Add VR instrumentation tests to FYI bot

Adds the chrome_public_test_apk instrumentation tests to the Android VR FYI
builder and limits it to VR-related tests using the functionality added in
https://bugs.chromium.org/p/chromium/issues/detail?id=658342

BUG=

Committed: https://crrev.com/d10df401216bf72f170da66d268e17c772e2972e
Cr-Commit-Position: refs/heads/master@{#435039}
==========

[commit-bot: I haz the power, 2016-11-29 18:46:50]

Patchset 1 (id:??) landed as
https://crrev.com/d10df401216bf72f170da66d268e17c772e2972e
Cr-Commit-Position: refs/heads/master@{#435039}