Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2537633002: Add VR instrumentation tests to FYI bot (Closed)

Created:
4 years ago by bsheedy
Modified:
4 years ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add VR instrumentation tests to FYI bot Adds the chrome_public_test_apk instrumentation tests to the Android VR FYI builder and limits it to VR-related tests using the functionality added in https://bugs.chromium.org/p/chromium/issues/detail?id=658342 BUG= Committed: https://crrev.com/d10df401216bf72f170da66d268e17c772e2972e Cr-Commit-Position: refs/heads/master@{#435039}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 chunk +9 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
bsheedy
PTAL, shouldn't affect anything except an FYI builder only a few people care about.
4 years ago (2016-11-28 22:45:23 UTC) #2
ncarter (slow)
I'm not familiar enough with this .json file to offer much of a review. https://codereview.chromium.org/2537633002/diff/1/testing/buildbot/chromium.fyi.json ...
4 years ago (2016-11-28 23:56:23 UTC) #3
bsheedy
https://codereview.chromium.org/2537633002/diff/1/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2537633002/diff/1/testing/buildbot/chromium.fyi.json#newcode901 testing/buildbot/chromium.fyi.json:901: "--test-filter", On 2016/11/28 23:56:23, ncarter wrote: > Is this ...
4 years ago (2016-11-29 00:11:54 UTC) #4
ncarter (slow)
lgtm
4 years ago (2016-11-29 06:27:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537633002/1
4 years ago (2016-11-29 17:37:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 18:41:48 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-29 18:46:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d10df401216bf72f170da66d268e17c772e2972e
Cr-Commit-Position: refs/heads/master@{#435039}

Powered by Google App Engine
This is Rietveld 408576698