Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2537603002: Linux Aura: Fix overlay shadows on notifications (Closed)

Created:
4 years ago by Tom Anderson
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, Peter Beverloo, tfarina, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Linux Aura: Fix overlay shadows on notifications >Linux Aura got support for translucent windows in CL: >https://chromium.googlesource.com/chromium/src.git/+/62ba78ffcdf525eb9ed640724e640fcf22fbbf87 > >Some Chrome widgets used a TRANSLUCENT_WINDOW opacity for widgets that >fade in or out, but that don't actually have an alpha mask. This was >to support a limitation on MS Windows where windows must be >translucent to fade. > >However, most Linux window managers only draw shadows on opaque >windows: that is, windows that do not have an alpha channel. Windows >that fade in or out may still have shadows since opacity is set as a >property of the toplevel window. > >Therefore, the solution is to use INFER_OPACITY for fading widgets so >it will work across platforms. TRANSLUCENT_WINDOW should only be used >on widgets that have alpha masks. > >BUG=640170 > >R=sky@chromium.org > >patch from issue 2398203002 at patchset 40001 >(http://crrev.com/2398203002#ps40001) > NOTRY=true NOPRESUBMIT=true BUG=640170 TBR=sky@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M ui/message_center/views/toast_contents_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537603002/1
4 years ago (2016-11-28 21:28:26 UTC) #2
commit-bot: I haz the power
4 years ago (2016-11-28 21:40:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698