Chromium Code Reviews
DescriptionLinux Aura: Fix overlay shadows on notifications
>Linux Aura got support for translucent windows in CL:
>https://chromium.googlesource.com/chromium/src.git/+/62ba78ffcdf525eb9ed640724e640fcf22fbbf87
>
>Some Chrome widgets used a TRANSLUCENT_WINDOW opacity for widgets that
>fade in or out, but that don't actually have an alpha mask. This was
>to support a limitation on MS Windows where windows must be
>translucent to fade.
>
>However, most Linux window managers only draw shadows on opaque
>windows: that is, windows that do not have an alpha channel. Windows
>that fade in or out may still have shadows since opacity is set as a
>property of the toplevel window.
>
>Therefore, the solution is to use INFER_OPACITY for fading widgets so
>it will work across platforms. TRANSLUCENT_WINDOW should only be used
>on widgets that have alpha masks.
>
>BUG=640170
>
>R=sky@chromium.org
>
>patch from issue 2398203002 at patchset 40001
>(http://crrev.com/2398203002#ps40001)
>
NOTRY=true
NOPRESUBMIT=true
BUG=640170
TBR=sky@chromium.org
Patch Set 1 #
Messages
Total messages: 4 (2 generated)
|
||||||||||||||||||||||||||||