Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 2537593002: PlzNavigate: Pass move information along with the response started notification for navigation requ… (Closed)

Created:
4 years ago by yzshen1
Modified:
4 years ago
Reviewers:
clamy
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, loading-reviews_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Pass move information along with the response started notification for navigation requests. BUG=652767 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/4434137b674aa5703a2f1e3cf10d6ad0bdac9ac2 Cr-Commit-Position: refs/heads/master@{#435427}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -25 lines) Patch
M content/browser/frame_host/navigation_request.h View 1 chunk +7 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/loader/navigation_resource_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_delegate.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_impl.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_impl.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M content/browser/loader/navigation_url_loader_impl_core.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_impl_core.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M content/test/test_navigation_url_loader.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/test/test_navigation_url_loader_delegate.h View 1 chunk +7 lines, -5 lines 0 comments Download
M content/test/test_navigation_url_loader_delegate.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
yzshen1
Hi, Camille. Please take a look. Thanks!
4 years ago (2016-11-28 21:16:39 UTC) #5
clamy
Thanks! Lgtm.
4 years ago (2016-11-30 17:41:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537593002/1
4 years ago (2016-11-30 17:49:04 UTC) #10
commit-bot: I haz the power
Failed to apply patch for content/browser/loader/navigation_url_loader_impl_core.h: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-11-30 19:29:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537593002/20001
4 years ago (2016-11-30 20:36:06 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 21:44:49 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-30 21:47:37 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4434137b674aa5703a2f1e3cf10d6ad0bdac9ac2
Cr-Commit-Position: refs/heads/master@{#435427}

Powered by Google App Engine
This is Rietveld 408576698