Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/android/offline_pages/offline_page_request_job.cc

Issue 2537563002: Making offline previews freshness configurable (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_request_job.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_request_job.cc b/chrome/browser/android/offline_pages/offline_page_request_job.cc
index fdc99500f4eb37f59bd1f1a2b43cc520a5fd3e1a..c9b50f5010bc3cbdabe032b0ba8f17c76f61bd23 100644
--- a/chrome/browser/android/offline_pages/offline_page_request_job.cc
+++ b/chrome/browser/android/offline_pages/offline_page_request_job.cc
@@ -312,10 +312,9 @@ RequestResult AccessOfflineFile(
// If the page is being loaded on a slow network, only use the offline page
// if it was created within the past day.
- // TODO(romax): Make the constant be policy driven.
if (network_state == NetworkState::PROHIBITIVELY_SLOW_NETWORK &&
base::Time::Now() - offline_page->creation_time >
- base::TimeDelta::FromDays(1)) {
+ previews::params::OfflinePreviewFreshnessDuration()) {
return RequestResult::PAGE_NOT_FRESH;
}
« no previous file with comments | « no previous file | components/previews/core/previews_experiments.h » ('j') | components/previews/core/previews_experiments.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698