Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2537553002: Handle top level fields with Kernel. (Closed)

Created:
4 years ago by Emily Fortuna
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle top level fields with Kernel. BUG=https://github.com/dart-lang/sdk/issues/27394 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/2529184b9d1aa4e55a52fdbb5ea3198d49c99cea

Patch Set 1 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 3 chunks +4 lines, -2 lines 2 comments Download
M tests/compiler/dart2js/kernel/literals_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Emily Fortuna
4 years ago (2016-12-07 00:20:01 UTC) #4
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2537553002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2537553002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode1060 pkg/compiler/lib/src/ssa/builder_kernel.dart:1060: _visitLocalSetter(declaration, initialValue); do we also need the potentiallyCheckOrTrustType ...
4 years ago (2016-12-07 17:38:00 UTC) #5
Emily Fortuna
https://codereview.chromium.org/2537553002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2537553002/diff/40001/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode1060 pkg/compiler/lib/src/ssa/builder_kernel.dart:1060: _visitLocalSetter(declaration, initialValue); On 2016/12/07 17:38:00, Siggi Cherem (dart-lang) wrote: ...
4 years ago (2016-12-07 18:08:14 UTC) #6
Emily Fortuna
4 years ago (2016-12-07 18:08:58 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:40001) manually as
2529184b9d1aa4e55a52fdbb5ea3198d49c99cea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698