Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2537533002: Use NoBarrier getters and setters for FixedArray. (Closed)

Created:
4 years ago by Hannes Payer (out of office)
Modified:
4 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use NoBarrier getters and setters for FixedArray. BUG=chromium:648568 Committed: https://crrev.com/385e8066463701cb614ed4f0582da96cb482da77 Cr-Commit-Position: refs/heads/master@{#41328}

Patch Set 1 #

Patch Set 2 : remove casts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M src/heap/spaces.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/objects-inl.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
ulan
lgtm
4 years ago (2016-11-28 18:22:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537533002/20001
4 years ago (2016-11-28 19:56:51 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 20:21:42 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-28 20:21:56 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/385e8066463701cb614ed4f0582da96cb482da77
Cr-Commit-Position: refs/heads/master@{#41328}

Powered by Google App Engine
This is Rietveld 408576698