Issue 253753005: Move bookmarks' production code to components/bookmarks

Issue 253753005: Move bookmarks' production code to components/bookmarks (Closed)

Created:
6 years, 7 months ago by sdefresne

Modified:
6 years, 7 months ago

Reviewers:
tfarina, blundell, willchan no longer on Chromium, sky

CC:
chromium-reviews, skanuj+watch_chromium.org, ben+aura_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, dcheng, rginda+watch_chromium.org, sadrul, tim+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, estade+watch_chromium.org, dominich, kalyank, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, yoshiki+watch_chromium.org, haitaol+watch_chromium.org, jfweitz+watch_chromium.org, chromium-apps-reviews_chromium.org, Jered, maniscalco+watch_chromium.org, tfarina, donnd+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su

Base URL:
https://chromium.googlesource.com/chromium/src.git@367656

Visibility:
Public.

More Reviews

Description

Move bookmarks' production code to components/bookmarks Move all the production code of bookmarks to the components folder as they form a cyclic graph and moving them separately would be more work for little gain. BUG=359565, 360637, 360640, 360643, 364881 TBR=willchan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267046

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix dependencies & includes #

Total comments: 1

Patch Set 3 : Fix compilation for win_chromium_x64_rel #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+310 lines, -4840 lines)			Patch
M	chrome/browser/android/bookmarks/bookmarks_bridge.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/android/bookmarks/managed_bookmarks_shim.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/bookmarks/partner_bookmarks_shim.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/bookmarks/partner_bookmarks_shim.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/provider/bookmark_model_observer_task.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/provider/chrome_browser_provider.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/android/signin/signin_manager_android.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/bookmark_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/bookmark_provider_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
D	chrome/browser/bookmarks/bookmark_codec.h	View		1 chunk	+0 lines, -207 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_codec.cc	View		1 chunk	+0 lines, -489 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_codec_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_expanded_state_tracker.h	View		1 chunk	+0 lines, -53 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc	View		1 chunk	+0 lines, -108 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_expanded_state_tracker_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_html_writer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_html_writer_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
D	chrome/browser/bookmarks/bookmark_index.h	View		1 chunk	+0 lines, -119 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_index.cc	View	1 2	1 chunk	+0 lines, -366 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_index_unittest.cc	View	1 2	3 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_model.h	View		1 chunk	+0 lines, -414 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_model.cc	View		1 chunk	+0 lines, -937 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_factory.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_node_data.h	View		1 chunk	+0 lines, -174 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_node_data.cc	View		1 chunk	+0 lines, -285 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_node_data_mac.cc	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_node_data_views.cc	View		1 chunk	+0 lines, -71 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h	View		1 chunk	+0 lines, -43 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm	View		1 chunk	+0 lines, -286 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_stats.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/bookmarks/bookmark_storage.h	View		1 chunk	+0 lines, -170 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_storage.cc	View		1 chunk	+0 lines, -188 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_test_helpers.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/bookmarks/bookmark_utils.h	View	1 2	1 chunk	+0 lines, -145 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_utils.cc	View	1 2	1 chunk	+0 lines, -430 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils_unittest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/bookmarks/chrome_bookmark_client.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
D	chrome/browser/bookmarks/scoped_group_bookmark_actions.h	View		1 chunk	+0 lines, -24 lines	0 comments	Download
D	chrome/browser/bookmarks/scoped_group_bookmark_actions.cc	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	chrome/browser/bookmarks/test_bookmark_client.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_commands_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/bookmarks/bookmarks_api.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/lazy_background_page_apitest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/favicon/DEPS	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/favicon/favicon_tab_helper.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/DEPS	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/android/android_provider_backend_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/android/bookmark_model_sql_handler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/expire_history_backend_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_backend_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_service.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_service_factory.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/in_memory_url_index.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/scored_history_match.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/url_index_private_data.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/external_process_importer_host.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/importer/profile_writer.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/profile_writer_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/bookmark_model_loaded_observer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_manager.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/bookmark_change_processor.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/bookmark_data_type_controller.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/bookmark_model_associator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_bookmark_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/bookmarks_helper.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/bookmarks_helper.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/aura/tab_contents/web_drag_bookmark_handler_aura.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/aura/tab_contents/web_drag_bookmark_handler_aura.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_drag_drop.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_editor.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_prompt_controller.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_tab_helper.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_utils.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/bookmark_item_applescript.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/bookmark_node_applescript.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tab_contents/web_drag_bookmark_handler_mac.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/view_id_util_browsertest.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_view_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/search/instant_extended_interactive_uitest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/sync/profile_signin_confirmation_helper.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar/toolbar_view_browsertest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar/wrench_menu.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/history_ui.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/undo/bookmark_renumber_observer.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/undo/bookmark_undo_service.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/undo/bookmark_undo_service.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/undo/bookmark_undo_service_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	2 chunks	+0 lines, -22 lines	0 comments	Download
M	chrome/test/base/testing_profile.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	components/bookmarks.gypi	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	components/bookmarks/DEPS	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_codec.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_codec.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_expanded_state_tracker.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_expanded_state_tracker.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_index.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_index.cc	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_model.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_model.cc	View		2 chunks	+6 lines, -6 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_node_data.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_node_data.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_node_data_mac.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_node_data_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_pasteboard_helper_mac.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_pasteboard_helper_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_storage.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_storage.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_utils.h	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	components/bookmarks/core/browser/bookmark_utils.cc	View	1 2	4 chunks	+5 lines, -4 lines	0 comments	Download
A +	components/bookmarks/core/browser/scoped_group_bookmark_actions.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/bookmarks/core/browser/scoped_group_bookmark_actions.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/base/models/tree_node_model.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 28 (0 generated)

Expand Messages | Collapse Messages

blundell

https://codereview.chromium.org/253753005/diff/1/components/bookmarks/DEPS File components/bookmarks/DEPS (right): https://codereview.chromium.org/253753005/diff/1/components/bookmarks/DEPS#newcode5 components/bookmarks/DEPS:5: "+components/favicon_base", You need to add all the necessary dependencies ...

6 years, 7 months ago (2014-04-28 12:58:03 UTC) #2

Mark P

Please wait until https://codereview.chromium.org/255423002/ lands; I would hope not to have to do a messy ...

6 years, 7 months ago (2014-04-28 14:38:13 UTC) #3

sdefresne

mpearson@: sure, I'll wait till your CL land. blundell@: PTAL

6 years, 7 months ago (2014-04-28 14:43:24 UTC) #4

tfarina

Thanks! After this lands, I will write the GN build file for this. lg https://codereview.chromium.org/253753005/diff/20001/chrome/browser/history/DEPS ...

6 years, 7 months ago (2014-04-28 16:09:58 UTC) #7