Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 253753004: MessageQueue uses Deque<OwnPtr<> > (Closed)

Created:
6 years, 7 months ago by Mikhail
Modified:
6 years, 7 months ago
Reviewers:
Erik Corry, eseidel
CC:
blink-reviews, ojan, adamk+blink_chromium.org, Inactive, abarth-chromium, Erik Corry, eseidel, Nico, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

MessageQueue uses Deque<OwnPtr<> > The MessageQueue class description comment contains the following: "Essentially, MessageQueue acts as a queue of OwnPtr<DataType>" This patch makes the MessageQueue actually contain the queue of OwnPtr's instead of queue of plain pointers (as it was before) making the code simpler and more compact. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -20 lines) Patch
M Source/wtf/MessageQueue.h View 9 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mikhail
PTAL
6 years, 7 months ago (2014-04-28 12:20:09 UTC) #1
eseidel
If this works, lgtm.
6 years, 7 months ago (2014-04-28 15:15:18 UTC) #2
Mikhail
On 2014/04/28 15:15:18, eseidel wrote: > If this works, lgtm. We've "DequeTest.OwnPtr" checking this, so ...
6 years, 7 months ago (2014-04-28 16:39:53 UTC) #3
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 7 months ago (2014-04-28 16:40:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/253753004/1
6 years, 7 months ago (2014-04-28 16:40:13 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 16:51:49 UTC) #6
Message was sent while issue was closed.
Change committed as 172777

Powered by Google App Engine
This is Rietveld 408576698