sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc - Issue 253753003: Enable use_sigaltstack=1 for ASan builds. This will ease the stack overflow detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc

Issue 253753003: Enable use_sigaltstack=1 for ASan builds. This will ease the stack overflow detection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move __NR_sigaltstack to baseline_policy.cc Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc

diff --git a/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc b/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc

index 792807ac72f4c1ee9d7d575e25247ac6cd1ab2b5..7daacfda5745498e8b22fa765f878fcf823d0c5c 100644

--- a/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc

+++ b/sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc

@@ -299,7 +299,6 @@ bool SyscallSets::IsAllowedSignalHandling(int sysno) {

case __NR_rt_sigsuspend:

case __NR_rt_sigtimedwait:

case __NR_rt_tgsigqueueinfo:

- case __NR_sigaltstack:

jln (very slow on Chromium) 2014/04/30 16:05:08 FYI you should dnot have removed this, the syscall

case __NR_signalfd:

case __NR_signalfd4:

#if defined(__i386__) || defined(__arm__)

« base/debug/sanitizer_options.cc ('K') | « sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc ('k') | no next file » | no next file with comments »