Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2537523002: [printing] Print properties backing store value and add a gdb macro for printing LayoutDescriptors. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[printing] Print properties backing store value and add a gdb macro for printing LayoutDescriptors. BUG= Committed: https://crrev.com/6fdd480ed4a48f268c35b3dd8359b774ebbd22cc Cr-Commit-Position: refs/heads/master@{#41326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M src/layout-descriptor.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-printer.cc View 4 chunks +23 lines, -5 lines 0 comments Download
M tools/gdbinit View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Igor Sheludko
PTAL
4 years ago (2016-11-28 18:11:34 UTC) #6
Jakob Kummerow
lgtm
4 years ago (2016-11-28 18:51:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537523002/20001
4 years ago (2016-11-28 19:26:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-11-28 19:27:59 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-28 19:28:13 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fdd480ed4a48f268c35b3dd8359b774ebbd22cc
Cr-Commit-Position: refs/heads/master@{#41326}

Powered by Google App Engine
This is Rietveld 408576698