Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2537513006: content: Cleanup class/struct forward declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, avayvod+watch_chromium.org, awdf+watch_chromium.org, blink-worker-reviews_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, cmumford, creis+watch_chromium.org, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, devtools-reviews_chromium.org, dtapuska+chromiumwatch_chromium.org, einbinder+watch-test-runner_chromium.org, feature-media-reviews_chromium.org, horo+watch_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jbauman+watch_chromium.org, jochen+watch_chromium.org, jsbell+idb_chromium.org, jsbell+serviceworker_chromium.org, kalyank, kinuko+fileapi, kinuko+serviceworker, kinuko+watch, loading-reviews_chromium.org, mac-reviews_chromium.org, mcasas+watch+vc_chromium.org, michaeln, miu+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, mlamouri+watch-notifications_chromium.org, mmenke, nasko+codewatch_chromium.org, nhiroki, nona+watch_chromium.org, Peter Beverloo, pfeldman, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, Randy Smith (Not in Mondays), serviceworker-reviews, shimazu+serviceworker_chromium.org, shuchen+watch_chromium.org, James Su, tzik, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in content header files. This is the 2nd time such a cleanup is done for content, but it should be the last as we have now an up-and-running presubmit check. BUG=662195 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/5b4678369a540c32dc19cd00f4cefbefb9f7b272 Cr-Commit-Position: refs/heads/master@{#435315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -130 lines) Patch
M content/browser/android/content_view_render_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/android/synchronous_compositor_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/appcache/appcache_request_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/compositor/software_output_device_mac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/loader/navigation_url_loader_impl_core.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/sync_resource_handler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/loader/test_resource_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/net/quota_policy_cookie_store.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_event_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/text_input_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognition_engine.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_child_frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/webui/web_ui_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/fileapi/webfilesystem_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/notifications/notification_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/child_process_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/indexed_db/indexed_db_key.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/indexed_db/indexed_db_key.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/service_manager/child_connection.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/web_ui_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/layouttest_support.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/web_contents_tester.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/utility/content_utility_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/child_frame_compositing_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/renderer_webmediaplayer_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/mojo_context_state.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/pepper/host_var_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_widget.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_widget_owner_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/speech_recognition_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_url_request_context_getter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/utility/utility_thread_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/zygote/zygote_linux.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
jbriance
4 years ago (2016-11-30 13:48:50 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-11-30 15:30:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537513006/1
4 years ago (2016-11-30 15:32:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 17:31:09 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-30 17:35:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b4678369a540c32dc19cd00f4cefbefb9f7b272
Cr-Commit-Position: refs/heads/master@{#435315}

Powered by Google App Engine
This is Rietveld 408576698