Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2537513005: PPC/s390: [stubs] Port builtin for Array.push fast-case from Crankshaft to TF (Closed)

Created:
4 years ago by JaideepBajwa
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [stubs] Port builtin for Array.push fast-case from Crankshaft to TF Port df2578d2ec630ccd08619e1f733da3f61e7ee380 Original Commit Message: Improves performance in simple, single element case by 5% and in multiple elements cases by 2%. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:608675 LOG=N Committed: https://crrev.com/f80961a7829e50e51e16dc8fc0ada96b625d4013 Cr-Commit-Position: refs/heads/master@{#41370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
4 years ago (2016-11-29 18:10:13 UTC) #1
john.yan
lgtm
4 years ago (2016-11-29 18:19:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537513005/1
4 years ago (2016-11-29 18:20:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 18:48:12 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-29 18:48:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f80961a7829e50e51e16dc8fc0ada96b625d4013
Cr-Commit-Position: refs/heads/master@{#41370}

Powered by Google App Engine
This is Rietveld 408576698