pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart - Issue 2537513004: Read overlay content when computing completions (issue 27887)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

Issue 2537513004: Read overlay content when computing completions (issue 27887) (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

index 5f782973971ba6e9a3512e34f2b8fdd93a0eb09b..70b2b448e4e55f0ae4dcc8d6466a74c46c4e4dd2 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

@@ -211,7 +211,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {

// then do not suppress the relevance of private members

var data = request.result != null

? request.result.content

- : request.context.getContents(request.source)?.data;

+ : request.sourceContents;

int offset = request.offset;

if (data != null && 0 < offset && offset <= data.length) {

bool isIdentifierChar(int index) {