pkg/analysis_server/lib/src/services/completion/completion_core.dart - Issue 2537513004: Read overlay content when computing completions (issue 27887)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_core.dart

Issue 2537513004: Read overlay content when computing completions (issue 27887) (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/provisional/completion/completion_core.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/completion_core.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/completion_core.dart b/pkg/analysis_server/lib/src/services/completion/completion_core.dart

index c43a144d0763dcf0e9c723b755ea96d8aa9ec86b..0a8b431e290e251d1ea9385f1b084efda267e844 100644

--- a/pkg/analysis_server/lib/src/services/completion/completion_core.dart

+++ b/pkg/analysis_server/lib/src/services/completion/completion_core.dart

@@ -87,12 +87,12 @@ class CompletionRequestImpl implements CompletionRequest {

* that can be used to filter the suggestions on the server side.

String get filterText {

- return context

- .getContents(source)

- .data

- .substring(replacementOffset, offset);

+ return sourceContents.substring(replacementOffset, offset);

}

+ @override

+ String get sourceContents => context.getContents(source)?.data;

/**

* Abort the current completion request.