Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: chrome/browser/prerender/prerender_unittest.cc

Issue 2537503002: [Prerender] Get the prerender mode from Finch field trial. (Closed)
Patch Set: Feature API Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_unittest.cc
diff --git a/chrome/browser/prerender/prerender_unittest.cc b/chrome/browser/prerender/prerender_unittest.cc
index 68d6c5bbddbb4f1c7dbcc19977ddbac1ab8352a3..445639d6f98388f41a141e34978f8e2bb6f15027 100644
--- a/chrome/browser/prerender/prerender_unittest.cc
+++ b/chrome/browser/prerender/prerender_unittest.cc
@@ -15,6 +15,7 @@
#include "base/message_loop/message_loop.h"
#include "base/metrics/field_trial.h"
#include "base/strings/stringprintf.h"
+#include "base/test/scoped_feature_list.h"
#include "base/test/simple_test_clock.h"
#include "base/test/simple_test_tick_clock.h"
#include "base/time/time.h"
@@ -411,12 +412,12 @@ class PrerenderTest : public testing::Test {
TEST_F(PrerenderTest, PrerenderRespectsDisableFlag) {
RestorePrerenderMode restore_prerender_mode;
ASSERT_TRUE(PrerenderManager::IsPrerenderingPossible());
- base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
- command_line->AppendSwitchASCII(
- switches::kPrerenderMode,
- switches::kPrerenderModeSwitchValueDisabled);
- prerender::ConfigurePrerender(*command_line);
- ASSERT_FALSE(PrerenderManager::IsPrerenderingPossible());
+ {
+ base::test::ScopedFeatureList scoped_feature_list;
+ scoped_feature_list.InitAndDisableFeature(kNoStatePrefetchFeature);
pasko 2016/12/01 16:47:58 please also test setting the "simple_load"
droger 2016/12/05 14:48:27 Done.
+ prerender::ConfigurePrerender();
+ ASSERT_FALSE(PrerenderManager::IsPrerenderingPossible());
+ }
}
TEST_F(PrerenderTest, PrerenderRespectsThirdPartyCookiesPref) {

Powered by Google App Engine
This is Rietveld 408576698