Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2537493003:
[PaymentRequest] Replace '' with 'unknown' in PaymentComplete. (Closed)
|
Created:
4 years ago by Hwanseung Lee Modified:
4 years ago CC:
chromium-reviews, blink-reviews, haraken, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, Hwanseung Lee(hs1217.lee) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[PaymentRequest] Replace '' with 'unknown' in PaymentComplete.
Replace the PaymentComplete enum value "" with the more descriptive "unknown".
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nrkDOHHgBAAJ
related spec list:
https://github.com/w3c/browser-payment-api/pull/312
https://w3c.github.io/browser-payment-api/#dom-paymentcomplete
BUG=670291
Committed: https://crrev.com/ae2f34d94bd078c054c17a25b0bfe5f896f7316b
Cr-Commit-Position: refs/heads/master@{#435857}
Patch Set 1 #
Messages
Total messages: 25 (17 generated)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [WIP] BUG= ========== to ========== replace '' with 'unknown' BUG=587995 ==========
Description was changed from ========== replace '' with 'unknown' BUG=587995 ========== to ========== [PaymentRequest] normative(PaymentComplete): replace '' with 'unknown' replace '' with 'unknown' in PaymentComplete. spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=587995 ==========
hs1217.lee@samsung.com changed reviewers: + rouslan@chromium.org
@rouslan PTAL. thank you.
Put this behind a runtime flag marked experimental. Put the link to intent to implement in description: https://groups.google.com/a/chromium.org/d/msg/blink-dev/B-8p5Ji-O9Q/nrkDOHHg... Link to the Open Web Platform (OWP) launch bug for this specific change instead of the generic PaymentRequest API: http://crbug.com/670291
jinho.bang@samsung.com changed reviewers: + foolip@chromium.org
jinho.bang@samsung.com changed reviewers: + jinho.bang@samsung.com
Non-owner comment,
Hi rouslan@ (and foolip@ as API Owner),
I'm not sure but this change looks trivial change because this change doesn't
break exisiting web.
According to the spec, the spec says that "UA should treat unrecognized result
values as the value 'unknown'."
*I think*, it means that the string parameter will treat as "unknown" if
complete() takes any string without "success" or fail".
Then, how can we put this behind a runtime flag? I could only think of throwing
an exception. But it won't be a right way.
As a extream example, we can imagine someone uses complete("unknown") before
this change.
It would have the same behavior to treat as complete("").
But after this change with runtime flag, if complete("unknown") would be behind
the flag, it might break exisiting web.
Someone will not able to use complete("unknown") anymore due to exception.
What do you think?
Good point. LGTM. See: https://groups.google.com/a/chromium.org/d/msg/blink-dev/B-8p5Ji-O9Q/5HyTDcLy...
Be sure to update the description first before landing: On 2016/12/01 15:09:04, rouslan wrote: > Put the link to intent to implement in description: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/B-8p5Ji-O9Q/nrkDOHHg... > > Link to the Open Web Platform (OWP) launch bug for this specific change instead > of the generic PaymentRequest API: > http://crbug.com/670291
Description was changed from ========== [PaymentRequest] normative(PaymentComplete): replace '' with 'unknown' replace '' with 'unknown' in PaymentComplete. spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=587995 ========== to ========== [PaymentRequest] normative(PaymentComplete): replace '' with 'unknown' replace '' with 'unknown' in PaymentComplete. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=587995 ==========
Description was changed from ========== [PaymentRequest] normative(PaymentComplete): replace '' with 'unknown' replace '' with 'unknown' in PaymentComplete. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=587995 ========== to ========== [PaymentRequest] normative(PaymentComplete): replace '' with 'unknown' replace '' with 'unknown' in PaymentComplete. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=587995, 670291 ==========
Description was changed from ========== [PaymentRequest] normative(PaymentComplete): replace '' with 'unknown' replace '' with 'unknown' in PaymentComplete. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=587995, 670291 ========== to ========== [PaymentRequest] Replace '' with 'unknown' in PaymentComplete. Replace the PaymentComplete enum value "" with the more descriptive "unknown". Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=587995, 670291 ==========
Description was changed from ========== [PaymentRequest] Replace '' with 'unknown' in PaymentComplete. Replace the PaymentComplete enum value "" with the more descriptive "unknown". Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=587995, 670291 ========== to ========== [PaymentRequest] Replace '' with 'unknown' in PaymentComplete. Replace the PaymentComplete enum value "" with the more descriptive "unknown". Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=670291 ==========
The CQ bit was checked by hs1217.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480644599465130, "parent_rev":
"76882ed2924ec187424a4102cd0f1909da3a1002", "commit_rev":
"e1144af45b8cef6eb42a945243da504a9b303e90"}
Message was sent while issue was closed.
Description was changed from ========== [PaymentRequest] Replace '' with 'unknown' in PaymentComplete. Replace the PaymentComplete enum value "" with the more descriptive "unknown". Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=670291 ========== to ========== [PaymentRequest] Replace '' with 'unknown' in PaymentComplete. Replace the PaymentComplete enum value "" with the more descriptive "unknown". Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=670291 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [PaymentRequest] Replace '' with 'unknown' in PaymentComplete. Replace the PaymentComplete enum value "" with the more descriptive "unknown". Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=670291 ========== to ========== [PaymentRequest] Replace '' with 'unknown' in PaymentComplete. Replace the PaymentComplete enum value "" with the more descriptive "unknown". Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nr... related spec list: https://github.com/w3c/browser-payment-api/pull/312 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete BUG=670291 Committed: https://crrev.com/ae2f34d94bd078c054c17a25b0bfe5f896f7316b Cr-Commit-Position: refs/heads/master@{#435857} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ae2f34d94bd078c054c17a25b0bfe5f896f7316b Cr-Commit-Position: refs/heads/master@{#435857} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
