Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2537483002: [regexp] Cache the correct initial prototype map (Closed)

Created:
4 years ago by jgruber
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Cache the correct initial prototype map If the prototype's map is not marked as fast, it is made fast after setup, breaking current RegExp fast path checks. BUG=v8:5339 Committed: https://crrev.com/1e3c5c90cdb1d2b2e5a950d72cb509cfc341e374 Cr-Commit-Position: refs/heads/master@{#41336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/bootstrapper.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
jgruber
4 years ago (2016-11-28 16:10:10 UTC) #4
jgruber
+ishell
4 years ago (2016-11-29 07:16:05 UTC) #8
Igor Sheludko
lgtm
4 years ago (2016-11-29 07:37:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537483002/1
4 years ago (2016-11-29 07:39:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 07:41:15 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 07:41:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e3c5c90cdb1d2b2e5a950d72cb509cfc341e374
Cr-Commit-Position: refs/heads/master@{#41336}

Powered by Google App Engine
This is Rietveld 408576698