Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2537453004: Restore default browser infobar icon to full-color Chrome icon. (Closed)

Created:
4 years ago by shrike
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore default browser infobar icon to full-color Chrome icon. Earlier this year the default browser infobar icon was changed to a stylized blue Chrome icon. This cl, per rpop@, reverts the icon to its original full-color version. R=sky@chromium.org BUG=654340 Committed: https://crrev.com/e33fc4517af8fe393a45ae3987b81a246e6ac160 Cr-Commit-Position: refs/heads/master@{#434839}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix header. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/startup/default_browser_infobar_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/default_browser_infobar_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
shrike
PTAL
4 years ago (2016-11-28 22:08:50 UTC) #1
sky
https://codereview.chromium.org/2537453004/diff/1/chrome/browser/ui/startup/default_browser_infobar_delegate.cc File chrome/browser/ui/startup/default_browser_infobar_delegate.cc (right): https://codereview.chromium.org/2537453004/diff/1/chrome/browser/ui/startup/default_browser_infobar_delegate.cc#newcode100 chrome/browser/ui/startup/default_browser_infobar_delegate.cc:100: int DefaultBrowserInfoBarDelegate::GetIconId() const { Don't you need to update ...
4 years ago (2016-11-28 22:50:29 UTC) #2
shrike
PTAL https://codereview.chromium.org/2537453004/diff/1/chrome/browser/ui/startup/default_browser_infobar_delegate.cc File chrome/browser/ui/startup/default_browser_infobar_delegate.cc (right): https://codereview.chromium.org/2537453004/diff/1/chrome/browser/ui/startup/default_browser_infobar_delegate.cc#newcode100 chrome/browser/ui/startup/default_browser_infobar_delegate.cc:100: int DefaultBrowserInfoBarDelegate::GetIconId() const { On 2016/11/28 22:50:29, sky ...
4 years ago (2016-11-28 23:23:00 UTC) #3
sky
LGTM
4 years ago (2016-11-29 00:08:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537453004/20001
4 years ago (2016-11-29 00:27:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 02:34:50 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-29 02:37:37 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e33fc4517af8fe393a45ae3987b81a246e6ac160
Cr-Commit-Position: refs/heads/master@{#434839}

Powered by Google App Engine
This is Rietveld 408576698