Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 2537453003: [arm][arm64] deal with holey array in the Apply builtin. (Closed)

Created:
4 years ago by Rodolph Perfetta (ARM)
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm][arm64] deal with holey array in the Apply builtin. BUG= Committed: https://crrev.com/1c1122978f97c9af7e67e64c80f78ffcac9f6d01 Cr-Commit-Position: refs/heads/master@{#41325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -11 lines) Patch
M src/builtins/arm/builtins-arm.cc View 3 chunks +31 lines, -6 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 4 chunks +42 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Rodolph Perfetta
this is a port of: https://codereview.chromium.org/2510043004/
4 years ago (2016-11-28 15:16:28 UTC) #2
Benedikt Meurer
Awesome, thanks a lot. LGTM!
4 years ago (2016-11-28 17:57:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537453003/1
4 years ago (2016-11-28 18:01:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 18:25:57 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-28 18:26:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c1122978f97c9af7e67e64c80f78ffcac9f6d01
Cr-Commit-Position: refs/heads/master@{#41325}

Powered by Google App Engine
This is Rietveld 408576698