Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2537453002: Add iOS ContextMenu histogram (Closed)

Created:
4 years ago by gambard
Modified:
4 years ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org, newt (away)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add iOS ContextMenu histogram Chrome on iOS uses the deprecated User Action "MobileContextMenu..." as part of the upstreaming, it should use the new histogram "ContextMenuOption". This CL adds the histograms needed by Chrome on iOS. BUG=669028 Committed: https://crrev.com/01d0304a40a5a7e0bb1da9a1d5fd68b8cd802c0d Cr-Commit-Position: refs/heads/master@{#434693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
gambard
PTAL.
4 years ago (2016-11-28 16:45:52 UTC) #2
gambard
+newt@ as histogram owner.
4 years ago (2016-11-28 16:47:56 UTC) #3
rkaplow
lgtm
4 years ago (2016-11-28 17:12:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537453002/1
4 years ago (2016-11-28 17:13:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 18:17:29 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-28 18:21:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01d0304a40a5a7e0bb1da9a1d5fd68b8cd802c0d
Cr-Commit-Position: refs/heads/master@{#434693}

Powered by Google App Engine
This is Rietveld 408576698