Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2537443002: [ios] Adds launchscreen image assets for Chromium. (Closed)

Created:
4 years ago by rohitrao (ping after 24h)
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds launchscreen image assets for Chromium. Introduces a new "ios_launchscreen_assets_target" GN variable to select which target provides assets for the launchscreen. BUG=665966, 666732 Committed: https://crrev.com/1fd5fa2a25779acfc0581dd8df18b7ae4e8525cc Cr-Commit-Position: refs/heads/master@{#434989}

Patch Set 1 #

Patch Set 2 : Add GN target. #

Patch Set 3 : Add final resources. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -0 lines) Patch
M ios/chrome/app/resources/BUILD.gn View 1 1 chunk +13 lines, -0 lines 0 comments Download
A ios/chrome/app/resources/launchscreen_images.xcassets/Contents.json View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/Contents.json View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo.png View 1 2 Binary file 0 comments Download
A ios/chrome/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo@2x.png View 1 2 Binary file 0 comments Download
A ios/chrome/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo@3x.png View 1 2 Binary file 0 comments Download
A ios/chrome/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/Contents.json View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name.png View 1 2 Binary file 0 comments Download
A ios/chrome/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name@2x.png View 1 2 Binary file 0 comments Download
A ios/chrome/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name@3x.png View 1 2 Binary file 0 comments Download
M ios/public/provider/chrome/browser/build_config.gni View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
rohitrao (ping after 24h)
Images are blank white placeholders for now, will swap in Chromium logos in a followup.
4 years ago (2016-11-28 16:02:49 UTC) #6
sdefresne
lgtm
4 years ago (2016-11-29 12:27:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537443002/40001
4 years ago (2016-11-29 14:06:06 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-29 15:10:04 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-29 15:14:04 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1fd5fa2a25779acfc0581dd8df18b7ae4e8525cc
Cr-Commit-Position: refs/heads/master@{#434989}

Powered by Google App Engine
This is Rietveld 408576698