Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2537433002: [inspector] Avoid unneeded heap allocations (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
kozy, Yang
CC:
devtools-reviews_chromium.org, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Avoid unneeded heap allocations v8::Global is movable, so no need to heap-allocate them. R=yangguo@chromium.org, kozyatinskiy@chromium.org Committed: https://crrev.com/5a6483ffda5ed0234657216cfee10a6389f76b76 Cr-Commit-Position: refs/heads/master@{#41379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/inspector/injected-script-native.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/inspector/injected-script-native.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Clemens Hammacher
4 years ago (2016-11-28 14:03:25 UTC) #5
kozy
lgtm, thanks! Could you introduce struct for std::pair<std::string, std::vector<std::tuple<uint32_t, int, int>>> in your next CL ...
4 years ago (2016-11-29 18:40:02 UTC) #6
Clemens Hammacher
On 2016/11/29 at 18:40:02, kozyatinskiy wrote: > lgtm, thanks! > > Could you introduce struct ...
4 years ago (2016-11-29 21:24:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537433002/1
4 years ago (2016-11-30 08:57:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 09:23:18 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-30 09:23:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a6483ffda5ed0234657216cfee10a6389f76b76
Cr-Commit-Position: refs/heads/master@{#41379}

Powered by Google App Engine
This is Rietveld 408576698