Don't use intrinsic width if our container's width is zero.

Don't use intrinsic width if our container's width is zero.

Since at least r798 we use a replaced element's intrinsic width if its
containing block has a width of zero. As a result our rendering of
width100percent-image.html has disagreed with all other browsers
(IE10, FF29, and Opera(Presto)) and
we display replaced elements when they should be invisible.

If our container has zero width then let our width be zero too.

BUG=235189
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173212

[ojan, 2014-04-29 19:56:11]

For posterity, can you include in this review or on the bug which other browsers
you tested. Assuming you tested at least Firefox and IE, lgtm.

[rhogan, 2014-04-29 20:03:37]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2014-04-29 20:04:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robhogan@gmail.com/253743008/1

[commit-bot: I haz the power, 2014-04-30 04:50:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 04:50:36]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 928.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
e77770f7eec65be398ea6287569eff9fd40504e9..51d43b5a1320fb79597867cea24b6c8002d1f8a5
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -928,6 +928,8 @@ crbug.com/364960
fast/multicol/newmulticol/layers-in-multicol.html [ Skip ]
 # Flaky on debug
 crbug.com/356780 [ Win ]
virtual/windows-directwrite/fast/text/sub-pixel/text-scaling-pixel.html [ Pass
ImageOnlyFailure Failure ]
 
+crbug.com/235189 fast/replaced/width100percent-image.html [ NeedsRebaseline ]
+
 # Ref tests fail as the reference rendering uses the default text rendering
options (GDI w/o AA)
 crbug.com/356780 [ Win ]
virtual/windows-directwrite/fast/text/bidi-isolate-hang-with-neutral.html [ Skip
]
 crbug.com/356780 [ Win ]
virtual/windows-directwrite/fast/text/bidi-override-isolate.html [ Skip ]

[rhogan, 2014-05-01 19:19:17]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2014-05-01 19:19:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robhogan@gmail.com/253743008/20001

[commit-bot: I haz the power, 2014-05-01 19:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-01 19:19:44]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 928.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
8c12f51a632f5bef02b10e6dc8ec0db9be9d864a..0c0f11f401076887998f74430b1b4ea3a1a8e943
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -928,6 +928,8 @@ crbug.com/364960
fast/multicol/newmulticol/layers-in-multicol.html [ Skip ]
 # Flaky on debug
 crbug.com/356780 [ Win ]
virtual/windows-directwrite/fast/text/sub-pixel/text-scaling-pixel.html [ Pass
ImageOnlyFailure Failure ]
 
+crbug.com/235189 fast/replaced/width100percent-image.html [ NeedsRebaseline ]
+
 # Ref tests fail as the reference rendering uses the default text rendering
options (GDI w/o AA)
 crbug.com/356780 [ Win ]
virtual/windows-directwrite/fast/text/bidi-isolate-hang-with-neutral.html [ Skip
]
 crbug.com/356780 [ Win ]
virtual/windows-directwrite/fast/text/bidi-override-isolate.html [ Skip ]

[rhogan, 2014-05-01 19:43:51]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2014-05-01 19:44:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robhogan@gmail.com/253743008/40001

[commit-bot: I haz the power, 2014-05-01 19:59:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-01 19:59:53]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink

[rhogan, 2014-05-02 13:53:19]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2014-05-02 13:53:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robhogan@gmail.com/253743008/40001

[commit-bot: I haz the power, 2014-05-02 13:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 13:53:55]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1002.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
20b71e17f98202f1f7593948a7d6d597ab0f3f12..e3f2b31059331e17d7291043c8544a67ce8831e8
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1002,6 +1002,8 @@ crbug.com/359960 compositing/iframes/scrolling-iframe.html
[ Pass Failure ]
 crbug.com/359960 virtual/softwarecompositing/iframes/scrolling-iframe.html [
Pass Failure ]
 crbug.com/359961 inspector/timeline/timeline-window-filter.html [ Pass Timeout
]
 
+crbug.com/235189 fast/replaced/width100percent-image.html [ NeedsRebaseline ]
+
 crbug.com/27987 fast/images/exif-orientation-height-image-document.html [
NeedsRebaseline ]
 crbug.com/27987 fast/images/image-zoom-to-25.html [ NeedsRebaseline ]
 crbug.com/27987
virtual/deferred/fast/images/exif-orientation-height-image-document.html [
NeedsRebaseline ]

[rhogan, 2014-05-02 15:16:17]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2014-05-02 15:16:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robhogan@gmail.com/253743008/60001

[commit-bot: I haz the power, 2014-05-02 15:35:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 15:35:13]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink

[rhogan, 2014-05-02 15:53:06]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2014-05-02 15:53:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robhogan@gmail.com/253743008/60001

[commit-bot: I haz the power, 2014-05-02 18:44:55]

Change committed as 173212