|
|
Chromium Code Reviews|
Created:
4 years ago by Dirk Pranke Modified:
4 years ago CC:
blink-reviews, chromium-reviews, Rick Byers Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ )
Reason for revert:
I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve.
See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/13447/steps/webkit_tests/logs/stdio for an example.
I'm speculatively reverting this for now, to see if things become happier.
Original issue's description:
> Reland of wptserve: Enable WPTServe by default.
TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG=618366
Committed: https://crrev.com/b5ce7e0a17e32d6d145124938a90220e9f9990c5
Cr-Commit-Position: refs/heads/master@{#435129}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
The CQ bit was checked by dpranke@chromium.org
Created Revert of wptserve: Enable WPTServe by default.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ ) Reason for revert: I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve. See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build... for an example. I'm speculatively reverting this for now, to see if things become happier. Original issue's description: > Reland of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2495613002/ ) > > Reason for revert: > The issue was resolved. Try to reland without any changes. > > Original issue's description: > > Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2482793002/ ) > > > > Reason for revert: > > > > I'm reverting this because I think > > > > imported/wpt/html/browsers/history/the-location-interface/reload_post_1.html > > > > started failing with the switch on windows, see > > > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%... > > > > and I'm the sheriff today. > > > > However, I'm also concerned that I think you missed my comments in #10. I don't think a 30% cycle time regression is okay, > > at least not without an explanation and a plan for addressing it. > > > > Original issue's description: > > > wptserve: Enable WPTServe by default. > > > > > > Feel free to revert this if you see stability issues of imported/wpt tests in > > > webkit_tests step. > > > > > > BUG=618366 > > > > > > Committed: https://crrev.com/311d6ccdab758c38b0394a06d054a4db15a5fa21 > > > Cr-Commit-Position: refs/heads/master@{#431186} > > > > TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=618366 > > > > Committed: https://crrev.com/05bb9406c894324faea17e0b4cc78bcfffafcff4 > > Cr-Commit-Position: refs/heads/master@{#431285} > > TBR=jsbell@chromium.org,qyearsley@chromium.org,dpranke@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=618366 > > Committed: https://crrev.com/340ad8ad4eceb6603867b1fc3f9b3b295d76d79d > Cr-Commit-Position: refs/heads/master@{#431820} TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=618366 ========== to ========== Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ ) Reason for revert: I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve. See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build... for an example. I'm speculatively reverting this for now, to see if things become happier. Original issue's description: > Reland of wptserve: Enable WPTServe by default. TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org NOTRY=true BUG=618366 ==========
Description was changed from ========== Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ ) Reason for revert: I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve. See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build... for an example. I'm speculatively reverting this for now, to see if things become happier. Original issue's description: > Reland of wptserve: Enable WPTServe by default. TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org NOTRY=true BUG=618366 ========== to ========== Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ ) Reason for revert: I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve. See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build... for an example. I'm speculatively reverting this for now, to see if things become happier. Original issue's description: > Reland of wptserve: Enable WPTServe by default. TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org NOTRY=true NOPRESUBMIT=true BUG=618366 ==========
The CQ bit was unchecked by dpranke@chromium.org
I'm skipping the try jobs and the presubmit because all sorts of things are broken on the tree and we might need this change in order for things to start recovering.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480476667531340, "parent_rev":
"d15cac81c8f370f9e16a11a0d9a034f154988883", "commit_rev":
"f815c8aaafb8a00ec5a045ac351cd5c2300488dd"}
Message was sent while issue was closed.
Description was changed from ========== Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ ) Reason for revert: I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve. See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build... for an example. I'm speculatively reverting this for now, to see if things become happier. Original issue's description: > Reland of wptserve: Enable WPTServe by default. TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org NOTRY=true NOPRESUBMIT=true BUG=618366 ========== to ========== Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ ) Reason for revert: I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve. See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build... for an example. I'm speculatively reverting this for now, to see if things become happier. Original issue's description: > Reland of wptserve: Enable WPTServe by default. TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org NOTRY=true NOPRESUBMIT=true BUG=618366 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ ) Reason for revert: I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve. See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build... for an example. I'm speculatively reverting this for now, to see if things become happier. Original issue's description: > Reland of wptserve: Enable WPTServe by default. TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org NOTRY=true NOPRESUBMIT=true BUG=618366 ========== to ========== Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ ) Reason for revert: I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve. See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build... for an example. I'm speculatively reverting this for now, to see if things become happier. Original issue's description: > Reland of wptserve: Enable WPTServe by default. TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org NOTRY=true NOPRESUBMIT=true BUG=618366 Committed: https://crrev.com/b5ce7e0a17e32d6d145124938a90220e9f9990c5 Cr-Commit-Position: refs/heads/master@{#435129} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b5ce7e0a17e32d6d145124938a90220e9f9990c5 Cr-Commit-Position: refs/heads/master@{#435129}
Message was sent while issue was closed.
lgtm, but many layout tests will fail by this.
Message was sent while issue was closed.
On 2016/11/30 03:42:53, tkent wrote: > lgtm, but many layout tests will fail by this. Yup, I'll deal with that once the system becomes otherwise healthy.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2633083002/ by tkent@chromium.org. The reason for reverting is: The problem was resolved. . |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
