Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2537413002: Revert of wptserve: Enable WPTServe by default. (Closed)

Created:
4 years ago by Dirk Pranke
Modified:
4 years ago
Reviewers:
tkent, qyearsley, jsbell
CC:
blink-reviews, chromium-reviews, Rick Byers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ ) Reason for revert: I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve. See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/13447/steps/webkit_tests/logs/stdio for an example. I'm speculatively reverting this for now, to see if things become happier. Original issue's description: > Reland of wptserve: Enable WPTServe by default. TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org NOTRY=true NOPRESUBMIT=true BUG=618366 Committed: https://crrev.com/b5ce7e0a17e32d6d145124938a90220e9f9990c5 Cr-Commit-Position: refs/heads/master@{#435129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Dirk Pranke
Created Revert of wptserve: Enable WPTServe by default.
4 years ago (2016-11-30 03:19:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537413002/1
4 years ago (2016-11-30 03:20:07 UTC) #3
Dirk Pranke
I'm skipping the try jobs and the presubmit because all sorts of things are broken ...
4 years ago (2016-11-30 03:26:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537413002/1
4 years ago (2016-11-30 03:31:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 03:34:08 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b5ce7e0a17e32d6d145124938a90220e9f9990c5 Cr-Commit-Position: refs/heads/master@{#435129}
4 years ago (2016-11-30 03:35:57 UTC) #14
tkent
lgtm, but many layout tests will fail by this.
4 years ago (2016-11-30 03:42:53 UTC) #15
Dirk Pranke
On 2016/11/30 03:42:53, tkent wrote: > lgtm, but many layout tests will fail by this. ...
4 years ago (2016-11-30 03:56:26 UTC) #16
tkent
3 years, 11 months ago (2017-01-16 03:38:15 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2633083002/ by tkent@chromium.org.

The reason for reverting is: The problem was resolved.
.

Powered by Google App Engine
This is Rietveld 408576698