ash/wm/frame_painter.cc - Issue 25374002: Fixes use after free caused by delete in RootWindowController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/frame_painter.cc

Issue 25374002: Fixes use after free caused by delete in RootWindowController (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Back to explicitly destroying with comment Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/frame_painter.cc

diff --git a/ash/wm/frame_painter.cc b/ash/wm/frame_painter.cc

index f92bc0b82d9e120b5ba41dae99bb214dbcf6f218..3368001f42f252cf6372c7d45d693e5e62d3cf06 100644

--- a/ash/wm/frame_painter.cc

+++ b/ash/wm/frame_painter.cc

@@ -177,8 +177,6 @@ bool IsSoloWindowHeaderCandidate(aura::Window* window) {

// a transparent solo-window header.

std::vector<Window*> GetWindowsForSoloHeaderUpdate(RootWindow* root_window) {

std::vector<Window*> windows;

- // During shutdown there may not be a workspace controller. In that case

- // we don't care about updating any windows.

// Avoid memory allocations for typical window counts.

windows.reserve(16);

// Collect windows from the desktop.

« no previous file with comments | « ash/root_window_controller_unittest.cc ('k') | ui/aura/window.h » ('j') | no next file with comments »