third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp - Issue 2537373005: [css-ui] Make caret-color animatable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

Issue 2537373005: [css-ui] Make caret-color animatable (Closed)

Patch Set: Come back to previous version but keep DCHECK in toStyleColor() Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/ColorPropertyFunctions.cpp ('K') | « third_party/WebKit/Source/core/css/StyleAutoColor.h ('k') | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp b/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

index d64c35f2942aff6a43716f039e6e339de6747fbc..710af227536c2c89fc686705c72fb0a2f8e9d38f 100644

--- a/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

@@ -421,6 +421,11 @@ void AnimatedStyleBuilder::applyProperty(CSSPropertyID property,

case CSSPropertyBoxShadow:

style->setBoxShadow(toAnimatableShadow(value)->getShadowList());

return;

+ case CSSPropertyCaretColor:

+ style->setCaretColor(toAnimatableColor(value)->getColor());

+ style->setVisitedLinkCaretColor(

+ toAnimatableColor(value)->visitedLinkColor());

+ return;

case CSSPropertyClip:

style->setClip(animatableValueToLengthBox(value, state));

return;