third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp - Issue 2537373005: [css-ui] Make caret-color animatable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 2537373005: [css-ui] Make caret-color animatable (Closed)

Patch Set: Apply suggested changes and add new composition test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/ColorPropertyFunctions.cpp ('K') | « third_party/WebKit/Source/core/animation/ColorPropertyFunctions.cpp ('k') | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

index 57e060c331517bd7792630475db1cfe7fa660113..2dd4b065cfbc1dafbad6f78401e9cdcbe7952b10 100644

--- a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

@@ -417,6 +417,12 @@ PassRefPtr<AnimatableValue> CSSAnimatableValueFactory::create(

CSSIdentifierValue::create(CSSValueAuto));

}

return createFromLengthBox(style.clip(), style);

+ case CSSPropertyCaretColor:

+ if (style.caretColor().isAutoColor()) {

+ return AnimatableUnknown::create(

+ CSSIdentifierValue::create(CSSValueAuto));

+ }

+ return createFromColor(property, style);

case CSSPropertyColor:

return createFromColor(property, style);

case CSSPropertyFillOpacity: