Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java

Issue 2537373004: [OfflinePages] Call NotifyInterrupted for pending requests (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java
index ea908f8d1827e625c6374597c1d099b43e39f125..08fe717dcf4eebe028ba1965eec77e213f6a5d05 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java
@@ -68,17 +68,16 @@ public class OfflinePageNotificationBridge {
* @param url URL of the page to download.
* @param startTime Time of the request.
* @param displayName Name to be displayed on notification.
- * @param isOfflining Whether the page is being offlined.
*/
@CalledByNative
public static void notifyDownloadProgress(
- Context context, String guid, String url, long startTime, String displayName,
- boolean isOfflining) {
+ Context context, String guid, String url, long startTime, String displayName) {
DownloadNotifier notifier = getDownloadNotifier(context);
if (notifier == null) return;
+ // Use -1 percentage for interdeterminate progress bar (until we have better value).
// TODO(qinmin): get the download percentage from native code,
- int percentage = isOfflining ? 0 : -1;
+ int percentage = -1;
DownloadInfo downloadInfo = new DownloadInfo.Builder()
.setIsOfflinePage(true)
.setDownloadGuid(guid)
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698