Use different source types for each ConnectJob subclass.

chrome/browser/resources/net_internals/source_entry.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var SourceEntry = (function() {
   'use strict';
 
   /**
    * A SourceEntry gathers all log entries with the same source.
    *
@@ skipping 66 matching lines @@
         return;
       }
 
       switch (e.source.type) {
         case EventSourceType.URL_REQUEST:
         // TODO(ricea): Remove SOCKET_STREAM after M41 is released.
         case EventSourceType.SOCKET_STREAM:
         case EventSourceType.HTTP_STREAM_JOB:
           this.description_ = e.params.url;
           break;
+        // TODO(davidben): Remove CONNECT_JOB after M57 is released.
         case EventSourceType.CONNECT_JOB:

[mmenke, 2016/11/30 15:09:24]

This works, even if EventSourceType.CONNECT_JOB is undefined (And even when
everything but EventSourceType.CONNECT_JOB is undefined)?

[davidben, 2016/11/30 17:37:49]

Apparently. EventSourceType.SOCKET_STREAM is also undefined. JavaScript just
spits out the value |undefined| and I guess e.source.type is not that value. For
better or worse, we seem to rely on this everywhere. :-/

(I would probably suggest that, if we cared, we post-process EventSourceType and
friends to set all unknown keys to -1 or something.)

[mmenke, 2016/11/30 20:51:59]

But....then we'd have multiple "case -1:", instead of multiple "case unknowns:".
 Just to verify, you have checked this works with old logs?  Multiple cases with
the same value (even if it's unknown) seems even weirder than one case with an
unknown.

[davidben, 2016/11/30 20:58:38]

Yup, works fine. JavaScript is fine with duplicate switch-cases and picks the
first match.

+        case EventSourceType.TRANSPORT_CONNECT_JOB:
+        case EventSourceType.SSL_CONNECT_JOB:
+        case EventSourceType.SOCKS_CONNECT_JOB:
+        case EventSourceType.HTTP_PROXY_CONNECT_JOB:
+        case EventSourceType.WEB_SOCKET_TRANSPORT_CONNECT_JOB:
           this.description_ = e.params.group_name;
           break;
         case EventSourceType.HOST_RESOLVER_IMPL_JOB:
         case EventSourceType.HOST_RESOLVER_IMPL_PROC_TASK:
           this.description_ = e.params.host;
           break;
         case EventSourceType.DISK_CACHE_ENTRY:
         case EventSourceType.MEMORY_CACHE_ENTRY:
           this.description_ = e.params.key;
           break;
@@ skipping 242 matching lines @@
           this.entries_,
           SourceTracker.getInstance().getPrivacyStripping(),
           SourceTracker.getInstance().getUseRelativeTimes() ?
               timeutil.getBaseTime() : 0,
           Constants.clientInfo.numericDate);
     },
   };
 
   return SourceEntry;
 })();