Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: base/trace_event/memory_dump_provider.h

Issue 2537363003: [memory-infra] Add support for polling memory totals in MemoryDumpManager (Closed)
Patch Set: Fixes. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/trace_event/memory_dump_manager_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_ 5 #ifndef BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_
6 #define BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_ 6 #define BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_
7 7
8 #include "base/base_export.h" 8 #include "base/base_export.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/process/process_handle.h" 10 #include "base/process/process_handle.h"
11 #include "base/trace_event/memory_dump_request_args.h" 11 #include "base/trace_event/memory_dump_request_args.h"
12 12
13 namespace base { 13 namespace base {
14 namespace trace_event { 14 namespace trace_event {
15 15
16 class ProcessMemoryDump; 16 class ProcessMemoryDump;
17 17
18 // The contract interface that memory dump providers must implement. 18 // The contract interface that memory dump providers must implement.
19 class BASE_EXPORT MemoryDumpProvider { 19 class BASE_EXPORT MemoryDumpProvider {
20 public: 20 public:
21 // Optional arguments for MemoryDumpManager::RegisterDumpProvider(). 21 // Optional arguments for MemoryDumpManager::RegisterDumpProvider().
22 struct Options { 22 struct Options {
23 Options() 23 Options()
24 : target_pid(kNullProcessId), 24 : target_pid(kNullProcessId),
25 dumps_on_single_thread_task_runner(false) {} 25 dumps_on_single_thread_task_runner(false),
26 is_fast_polling_supported(false) {}
26 27
27 // If the dump provider generates dumps on behalf of another process, 28 // If the dump provider generates dumps on behalf of another process,
28 // |target_pid| contains the pid of that process. 29 // |target_pid| contains the pid of that process.
29 // The default value is kNullProcessId, which means that the dump provider 30 // The default value is kNullProcessId, which means that the dump provider
30 // generates dumps for the current process. 31 // generates dumps for the current process.
31 ProcessId target_pid; 32 ProcessId target_pid;
32 33
33 // |dumps_on_single_thread_task_runner| is true if the dump provider runs on 34 // |dumps_on_single_thread_task_runner| is true if the dump provider runs on
34 // a SingleThreadTaskRunner, which is usually the case. It is faster to run 35 // a SingleThreadTaskRunner, which is usually the case. It is faster to run
35 // all providers that run on the same thread together without thread hops. 36 // all providers that run on the same thread together without thread hops.
36 bool dumps_on_single_thread_task_runner; 37 bool dumps_on_single_thread_task_runner;
38
39 // Set to true if the dump provider implementation supports high frequency
40 // polling. Only providers running without task runner affinity are
41 // supported.
42 bool is_fast_polling_supported;
37 }; 43 };
38 44
39 virtual ~MemoryDumpProvider() {} 45 virtual ~MemoryDumpProvider() {}
40 46
41 // Called by the MemoryDumpManager when generating memory dumps. 47 // Called by the MemoryDumpManager when generating memory dumps.
42 // The |args| specify if the embedder should generate light/heavy dumps on 48 // The |args| specify if the embedder should generate light/heavy dumps on
43 // dump requests. The embedder should return true if the |pmd| was 49 // dump requests. The embedder should return true if the |pmd| was
44 // successfully populated, false if something went wrong and the dump should 50 // successfully populated, false if something went wrong and the dump should
45 // be considered invalid. 51 // be considered invalid.
46 // (Note, the MemoryDumpManager has a fail-safe logic which will disable the 52 // (Note, the MemoryDumpManager has a fail-safe logic which will disable the
47 // MemoryDumpProvider for the entire trace session if it fails consistently). 53 // MemoryDumpProvider for the entire trace session if it fails consistently).
48 virtual bool OnMemoryDump(const MemoryDumpArgs& args, 54 virtual bool OnMemoryDump(const MemoryDumpArgs& args,
49 ProcessMemoryDump* pmd) = 0; 55 ProcessMemoryDump* pmd) = 0;
50 56
51 // Called by the MemoryDumpManager when an allocator should start or stop 57 // Called by the MemoryDumpManager when an allocator should start or stop
52 // collecting extensive allocation data, if supported. 58 // collecting extensive allocation data, if supported.
53 virtual void OnHeapProfilingEnabled(bool enabled) {} 59 virtual void OnHeapProfilingEnabled(bool enabled) {}
54 60
61 // Quickly record the total memory usage in |memory_total|. This method will
62 // be called only when the dump provider registration has
63 // |is_fast_polling_supported| set to true. This method is used for polling at
64 // high frequency for detecting peaks. See comment on
65 // |is_fast_polling_supported| option if you need to override this method.
66 virtual void PollFastMemoryTotal(uint64_t* memory_total) {}
67
68 // Notifies polling enabled and disabled states. Polling is set enabled before
69 // the first call to PollFastMemoryTotal() and set disabled after the last
70 // call to PollFastMemoryTotal() in a tracing session.
71 virtual void SetFastMemoryPollingEnabled(bool enabled) {}
72
55 protected: 73 protected:
56 MemoryDumpProvider() {} 74 MemoryDumpProvider() {}
57 75
58 DISALLOW_COPY_AND_ASSIGN(MemoryDumpProvider); 76 DISALLOW_COPY_AND_ASSIGN(MemoryDumpProvider);
59 }; 77 };
60 78
61 } // namespace trace_event 79 } // namespace trace_event
62 } // namespace base 80 } // namespace base
63 81
64 #endif // BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_ 82 #endif // BASE_TRACE_EVENT_MEMORY_DUMP_PROVIDER_H_
OLDNEW
« no previous file with comments | « base/trace_event/memory_dump_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698