Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2537363002:
Handling firstRectForCharacterRange when range argument has invalid range (Mac) (Closed)
DescriptionHandling firstRectForCharacterRange when range argument has invalid range (Mac)
When the value of requested range is invalid, the TextInputClientObserver will return
the rect corresponding to the current cursor position instead.
BUG=664679
Committed: https://crrev.com/98dc75fb675ed90a69f1cb29d724bab7aa9650ef
Cr-Commit-Position: refs/heads/master@{#435691}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Using isNull() instead of comparing agains -1 #Messages
Total messages: 26 (16 generated)
The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ekaramad@chromium.org changed reviewers: + erikchen@chromium.org
erikchen@ Could you please take a look at this change? I wonder if this way of handling invalid range makes sense. I figured we should as well return the current cursor position as the bounds.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
https://codereview.chromium.org/2537363002/diff/1/content/renderer/text_input... File content/renderer/text_input_client_observer.cc (right): https://codereview.chromium.org/2537363002/diff/1/content/renderer/text_input... content/renderer/text_input_client_observer.cc:32: return range.startOffset() != -1 ? static_cast<uint32_t>(range.startOffset()) should this be an IsNull check instead of != -1?
The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL. Thanks! https://codereview.chromium.org/2537363002/diff/1/content/renderer/text_input... File content/renderer/text_input_client_observer.cc (right): https://codereview.chromium.org/2537363002/diff/1/content/renderer/text_input... content/renderer/text_input_client_observer.cc:32: return range.startOffset() != -1 ? static_cast<uint32_t>(range.startOffset()) On 2016/11/30 15:24:33, erikchen wrote: > should this be an IsNull check instead of != -1? I believe yes. Thanks!
lgtm
ekaramad@chromium.org changed reviewers: + avi@chromium.org
Thanks Erik! Adding avi@ as the contnet/ owner reviewer. Avi, could you please take a look?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Thanks for the reviews!
The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ekaramad@chromium.org
The CQ bit was checked by ekaramad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480618417160760,
"parent_rev": "00fb902e6516c6886a2863a13edab911a6d1a765", "commit_rev":
"895a1942daeadab98faeee4efc1722d89d85f8b6"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Handling firstRectForCharacterRange when range argument has invalid range (Mac) When the value of requested range is invalid, the TextInputClientObserver will return the rect corresponding to the current cursor position instead. BUG=664679 ========== to ========== Handling firstRectForCharacterRange when range argument has invalid range (Mac) When the value of requested range is invalid, the TextInputClientObserver will return the rect corresponding to the current cursor position instead. BUG=664679 Committed: https://crrev.com/98dc75fb675ed90a69f1cb29d724bab7aa9650ef Cr-Commit-Position: refs/heads/master@{#435691} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/98dc75fb675ed90a69f1cb29d724bab7aa9650ef Cr-Commit-Position: refs/heads/master@{#435691} |
