Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2537343006: services: Cleanup class/struct fwd declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services: Cleanup class/struct fwd declarations Remove useless class and struct forward declarations, and add missing ones in services header files. BUG=662195 Committed: https://crrev.com/fd5b71eb1b32259cbebfbd9fccc9c420bcc39809 Cr-Commit-Position: refs/heads/master@{#436340}

Patch Set 1 #

Patch Set 2 : Rebase on top of master #

Patch Set 3 : Rebase on top of master #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M services/navigation/navigation.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/preferences/public/cpp/pref_observer_store.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/cpp/context_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/public/cpp/gpu/mojo_gpu_memory_buffer_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree_client_setup.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/public/cpp/window.h View 2 chunks +0 lines, -6 lines 0 comments Download
M services/ui/public/cpp/window_compositor_frame_sink.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/public/cpp/window_tree_client_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/service.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M services/ui/ws/event_dispatcher.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/focus_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/frame_generator.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/gpu_service_proxy_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/platform_display.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/platform_display_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/server_window.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/server_window_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/ws/test_server_window_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/ws/user_display_manager_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M services/ui/ws/window_manager_display_root.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/window_manager_window_tree_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/window_server_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/ws/window_server_test_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/ws/window_tree.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
jbriance
4 years ago (2016-12-01 09:27:55 UTC) #2
Fady Samuel
lgtm
4 years ago (2016-12-01 12:40:06 UTC) #4
jbriance
4 years ago (2016-12-02 09:16:46 UTC) #12
Ken Rockot(use gerrit already)
lgtm
4 years ago (2016-12-05 17:40:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537343006/40001
4 years ago (2016-12-05 17:42:02 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-05 17:50:48 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-05 17:53:02 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fd5b71eb1b32259cbebfbd9fccc9c420bcc39809
Cr-Commit-Position: refs/heads/master@{#436340}

Powered by Google App Engine
This is Rietveld 408576698