Add SurfaceReference class.

Add SurfaceReference class.

Add a simple class SurfaceReference that holds a parent and child
SurfaceId. Also add Mojo struct and StructTraits for use over IPC.

Update SurfaceId and LocalFrameId struct traits slightly to avoid
unnecessary copies. This requires a friend declaration but it seems
reasonable and is done elsewhere.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/c142d1d1f52fd97e463944d0666702c920eb58b2
Cr-Commit-Position: refs/heads/master@{#436423}

[kylechar, 2016-11-30 16:37:49]

Description was changed from

==========
Add SurfaceReference class.

Add a simple class SurfaceReference that holds a parent and child
SurfaceId. Also add Mojo struct and StructTraits for use over IPC.

Update SurfaceId and LocalFrameId struct traits slightly to avoid
unnecessary copies. This requires a friend declaration but it seems
reasonable and is done elsewhere.

BUG=659227
==========

to

==========
Add SurfaceReference class.

Add a simple class SurfaceReference that holds a parent and child
SurfaceId. Also add Mojo struct and StructTraits for use over IPC.

Update SurfaceId and LocalFrameId struct traits slightly to avoid
unnecessary copies. This requires a friend declaration but it seems
reasonable and is done elsewhere.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2016-11-30 17:11:03]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 17:11:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 17:16:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 17:16:23]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kylechar, 2016-11-30 17:24:23]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 17:25:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 18:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 18:29:19]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-11-30 18:30:45]

kylechar@chromium.org changed reviewers:
+ tsepez@chromium.org, vmpstr@chromium.org

[kylechar, 2016-11-30 18:30:46]

+vmpstr for general cc/OWNERS review
+tsepez for security review
+fsamuel FYI

[Tom Sepez, 2016-11-30 18:35:05]

lgtm

https://codereview.chromium.org/2537343004/diff/60001/cc/ipc/local_frame_id_s...
File cc/ipc/local_frame_id_struct_traits.h (right):

https://codereview.chromium.org/2537343004/diff/60001/cc/ipc/local_frame_id_s...
cc/ipc/local_frame_id_struct_traits.h:28: if (!data.ReadNonce(&out->nonce_))
nit: or just
  return data.ReadNonce(&out->nonce_);

[kylechar, 2016-11-30 22:44:59]

https://codereview.chromium.org/2537343004/diff/60001/cc/ipc/local_frame_id_s...
File cc/ipc/local_frame_id_struct_traits.h (right):

https://codereview.chromium.org/2537343004/diff/60001/cc/ipc/local_frame_id_s...
cc/ipc/local_frame_id_struct_traits.h:28: if (!data.ReadNonce(&out->nonce_))
On 2016/11/30 18:35:05, Tom Sepez wrote:
> nit: or just
>   return data.ReadNonce(&out->nonce_);

Done.

[vmpstr, 2016-12-02 19:33:35]

lgtm

https://codereview.chromium.org/2537343004/diff/80001/cc/ipc/traits_test_serv...
File cc/ipc/traits_test_service.mojom (right):

https://codereview.chromium.org/2537343004/diff/80001/cc/ipc/traits_test_serv...
cc/ipc/traits_test_service.mojom:61: EchoSurfaceReference(SurfaceReference s) =>
(SurfaceReference ref);
What are the variable names here? The rest of the items on the rhs are "pass",
but here it's "ref" I'm sure it doesn't really matter, but I'm just curious.

https://codereview.chromium.org/2537343004/diff/80001/cc/surfaces/surface_ref...
File cc/surfaces/surface_reference.h (right):

https://codereview.chromium.org/2537343004/diff/80001/cc/surfaces/surface_ref...
cc/surfaces/surface_reference.h:19: class SurfaceReference {
Can you add a small class comment briefly describing the class

[kylechar, 2016-12-02 20:16:22]

kylechar@chromium.org changed reviewers:
+ rockot@chromium.org

[kylechar, 2016-12-02 20:16:23]

Thanks!

+rockot for DEP on mojo/public/cpp/bindings/struct_traits.h

https://codereview.chromium.org/2537343004/diff/80001/cc/ipc/traits_test_serv...
File cc/ipc/traits_test_service.mojom (right):

https://codereview.chromium.org/2537343004/diff/80001/cc/ipc/traits_test_serv...
cc/ipc/traits_test_service.mojom:61: EchoSurfaceReference(SurfaceReference s) =>
(SurfaceReference ref);
On 2016/12/02 19:33:35, vmpstr wrote:
> What are the variable names here? The rest of the items on the rhs are "pass",
> but here it's "ref" I'm sure it doesn't really matter, but I'm just curious.

They're the variable names that get used in the autogen code. I changed the
output variable name to be "pass" too just for consistency but it doesn't make a
difference.

https://codereview.chromium.org/2537343004/diff/80001/cc/surfaces/surface_ref...
File cc/surfaces/surface_reference.h (right):

https://codereview.chromium.org/2537343004/diff/80001/cc/surfaces/surface_ref...
cc/surfaces/surface_reference.h:19: class SurfaceReference {
On 2016/12/02 19:33:35, vmpstr wrote:
> Can you add a small class comment briefly describing the class

Done.

[Ken Rockot(use gerrit already), 2016-12-05 20:38:25]

lgtm

[kylechar, 2016-12-05 20:55:44]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-12-05 20:55:44]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2537343004/#ps100001
(title: "Fixes.")

[commit-bot: I haz the power, 2016-12-05 20:56:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 22:23:14]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480971344387860,
"parent_rev": "a2438ed9421f78922277e899e4befea6b289109d", "commit_rev":
"7ff9b542eb8c5a1dfcb32d0a9adbe8796a57757e"}

[commit-bot: I haz the power, 2016-12-05 22:23:46]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-05 22:27:27]

Description was changed from

==========
Add SurfaceReference class.

Add a simple class SurfaceReference that holds a parent and child
SurfaceId. Also add Mojo struct and StructTraits for use over IPC.

Update SurfaceId and LocalFrameId struct traits slightly to avoid
unnecessary copies. This requires a friend declaration but it seems
reasonable and is done elsewhere.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add SurfaceReference class.

Add a simple class SurfaceReference that holds a parent and child
SurfaceId. Also add Mojo struct and StructTraits for use over IPC.

Update SurfaceId and LocalFrameId struct traits slightly to avoid
unnecessary copies. This requires a friend declaration but it seems
reasonable and is done elsewhere.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/c142d1d1f52fd97e463944d0666702c920eb58b2
Cr-Commit-Position: refs/heads/master@{#436423}
==========

[commit-bot: I haz the power, 2016-12-05 22:27:28]

Patchset 6 (id:??) landed as
https://crrev.com/c142d1d1f52fd97e463944d0666702c920eb58b2
Cr-Commit-Position: refs/heads/master@{#436423}