Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2537323002:
Optimize WebURL::protocolIs (Closed)
|
Created:
4 years ago by Charlie Harrison Modified:
4 years ago Reviewers:
kinuko CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOptimize WebURL::protocolIs
The top-level protocolIs() method in KURL does extra work including
scheme canonicalization that isn't necessary if the input is already
canonicalized.
This patch uses the parsed structure of the WebURL for an efficient
StringView-based check.
BUG=348655
Committed: https://crrev.com/f08b4560dee36e6db75e84dad3ec8fbb80622639
Cr-Commit-Position: refs/heads/master@{#435149}
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
csharrison@chromium.org changed reviewers: + kinuko@chromium.org
kinuko, PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Hmm... ok, lgtm
On 2016/11/30 04:53:53, kinuko wrote: > Hmm... ok, lgtm thanks!
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480482108526390, "parent_rev":
"bbd9c96eadea63e5761d208689505acfd3d1b528", "commit_rev":
"a587a1f9d9c3245af62720382547b43b8ff2f016"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Optimize WebURL::protocolIs The top-level protocolIs() method in KURL does extra work including scheme canonicalization that isn't necessary if the input is already canonicalized. This patch uses the parsed structure of the WebURL for an efficient StringView-based check. BUG=348655 ========== to ========== Optimize WebURL::protocolIs The top-level protocolIs() method in KURL does extra work including scheme canonicalization that isn't necessary if the input is already canonicalized. This patch uses the parsed structure of the WebURL for an efficient StringView-based check. BUG=348655 Committed: https://crrev.com/f08b4560dee36e6db75e84dad3ec8fbb80622639 Cr-Commit-Position: refs/heads/master@{#435149} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f08b4560dee36e6db75e84dad3ec8fbb80622639 Cr-Commit-Position: refs/heads/master@{#435149} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
