Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 2537303003: Fix memory corruption related to load blocking resource move (Closed)
Patch Set: CHECK Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
index 1c9fd3a59b1b6274383c87e2b2060006e5405300..38f3f95df33dae0441ef104c17bec506eb79720a 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
@@ -451,6 +451,7 @@ void ResourceFetcher::moveCachedNonBlockingResourceToBlocking(
// to not-block even after being preloaded and discovered.
if (resource && resource->loader() &&
resource->isLoadEventBlockingResourceType() &&
+ m_nonBlockingLoaders.contains(resource->loader()) &&
resource->isLinkPreload() && !request.forPreload()) {
m_nonBlockingLoaders.remove(resource->loader());
m_loaders.add(resource->loader());
@@ -1280,6 +1281,9 @@ void ResourceFetcher::acceptDataFromThreadedReceiver(unsigned long identifier,
}
void ResourceFetcher::moveResourceLoaderToNonBlocking(ResourceLoader* loader) {
+ DCHECK(loader);
+ // TODO(yoav): Convert CHECK to DCHECK if no crash reports come in.
+ CHECK(m_loaders.contains(loader));
m_nonBlockingLoaders.add(loader);
m_loaders.remove(loader);
}
@@ -1324,6 +1328,7 @@ bool ResourceFetcher::startLoad(Resource* resource) {
}
void ResourceFetcher::removeResourceLoader(ResourceLoader* loader) {
+ DCHECK(loader);
if (m_loaders.contains(loader))
m_loaders.remove(loader);
else if (m_nonBlockingLoaders.contains(loader))
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698