Translate: New Bubble UX (for the view toolkit)

chrome/browser/ui/translate/translate_bubble_factory.cc

Index: chrome/browser/ui/translate/translate_bubble_factory.cc
diff --git a/chrome/browser/ui/translate/translate_bubble_factory.cc b/chrome/browser/ui/translate/translate_bubble_factory.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6bb0b5e7b057d9950cac52faf9611ae7067a0bfd
--- /dev/null
+++ b/chrome/browser/ui/translate/translate_bubble_factory.cc
@@ -0,0 +1,44 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/translate/translate_bubble_factory.h"
+
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_window.h"
+
+namespace {
+
+void ShowDefault(BrowserWindow* window,
+                 content::WebContents* web_contents,
+                 TranslateBubbleModel::ViewState view_state) {
+  // |window| might be null when testing.
+  if (!window)
+    return;
+  window->ShowTranslateBubble(web_contents, view_state);
+}
+
+}  // namespace
+
+TranslateBubbleFactory::~TranslateBubbleFactory() {
+}
+
+// static
+void TranslateBubbleFactory::Show(BrowserWindow* window,
+                                  content::WebContents* web_contents,
+                                  TranslateBubbleModel::ViewState view_state) {
+  if (current_factory_) {
+    current_factory_->ShowImplementation(window, web_contents, view_state);
+    return;
+  }
+
+  ShowDefault(window, web_contents, view_state);
+}
+
+// static
+void TranslateBubbleFactory::SetFactory(TranslateBubbleFactory* factory) {
+  current_factory_ = factory;

[sky, 2013/10/23 14:43:29]

Shouldn't you delete old? And document ownership.

[hajimehoshi, 2013/10/24 11:31:14]

Done (added a comment to the header).  Is it better to have
TranslateBubbleFactory take the owner?  If so, maybe |current_factory_| should
be deleted by AtExitManager like what Singleton does?

+}
+
+// static
+TranslateBubbleFactory*  TranslateBubbleFactory::current_factory_ = NULL;