Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4353)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 25373009: Translate: New Bubble UX (for the view toolkit) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sky's review (2) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index f24b9360031a742de7f1409cae430098802b1d34..b56ad38fdba67da6aaf004b116b0ca0b8bfe80a1 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -160,6 +160,11 @@ bool TranslateBubbleView::IsShowing() {
return translate_bubble_view_ != NULL;
}
+// static
+TranslateBubbleView* TranslateBubbleView::GetCurrentBubble() {
+ return translate_bubble_view_;
+}
+
void TranslateBubbleView::Init() {
SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical,
0, 0, 0));
@@ -187,7 +192,7 @@ void TranslateBubbleView::ButtonPressed(views::Button* sender,
}
void TranslateBubbleView::WindowClosing() {
- if (!translate_executed_)
+ if (!translate_executed_ && !browser_->IsAttemptingToCloseBrowser())
model_->TranslationDeclined();
// We have to reset |translate_bubble_view_| here, not in our destructor,

Powered by Google App Engine
This is Rietveld 408576698