Translate: New Bubble UX (for the view toolkit)

chrome/browser/translate/translate_bubble_showable.h

Index: chrome/browser/translate/translate_bubble_showable.h
diff --git a/chrome/browser/translate/translate_bubble_showable.h b/chrome/browser/translate/translate_bubble_showable.h
new file mode 100644
index 0000000000000000000000000000000000000000..268a6aaaf4567f5038ce59682303c21f1d97373c
--- /dev/null
+++ b/chrome/browser/translate/translate_bubble_showable.h
@@ -0,0 +1,24 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_BUBBLE_SHOWABLE_H_
+#define CHROME_BROWSER_TRANSLATE_TRANSLATE_BUBBLE_SHOWABLE_H_
+
+#include "chrome/browser/ui/translate/translate_bubble_model.h"
+
+namespace content {
+class WebContents;
+}
+
+// The interface to show the translate bubble.
+class TranslateBubbleShowable {
+ public:
+  virtual ~TranslateBubbleShowable() {}
+
+  // Shows the Translate bubble.
+  virtual void Show(content::WebContents* web_contents,

[sky, 2013/10/22 16:09:22]

How about putting this in browser_dialogs and naming it ShowTranslateBubble? If
it needs a browser or webcontents, make it take those. The function should take
everything it needs and not have to search through the browserlist. The
implementation should reside in the approriate platforms, eg c/b/u/views.

If you went this route to make it mockable, then the following would be better:

class TranslateBubbleFactory {
 public:
  static void Show(XXX)  // internally uses factory, if no factory then calls
ShowImplementation().
  static void SetFactory(...);

 protected:
  virtual void ShowImplementation();

};

Platforms then implement TranslateBubbleFactory::ShowImplementation

Also, this should be in the chrome/browser/ui.

[sky, 2013/10/22 16:16:00]

Also, you could keep the Show method in browser_dialogs like I outlined and have
TranslateBubbleFactory::Show() invoke it if no factory is set. That way
ShowImplementation() can remain pure virtual.

[hajimehoshi, 2013/10/23 10:45:09]

Done. Showing the bubble via BrowserWindow is already platform-independent, so
just created TranslateBubbleFactory.

+                    TranslateBubbleModel::ViewState view_state) = 0;
+};
+
+#endif  // CHROME_BROWSER_TRANSLATE_TRANSLATE_BUBBLE_SHOWABLE_H_