Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2500)

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 25373009: Translate: New Bubble UX (for the view toolkit) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add 'Try again' button; rename enum names Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar_view.cc
diff --git a/chrome/browser/ui/views/toolbar_view.cc b/chrome/browser/ui/views/toolbar_view.cc
index 20e815606cfcdbae442134183422bf79cc21883d..c29f0538ab6a29cd614cf5d728080951bcedc3e2 100644
--- a/chrome/browser/ui/views/toolbar_view.cc
+++ b/chrome/browser/ui/views/toolbar_view.cc
@@ -31,6 +31,7 @@
#include "chrome/browser/ui/views/home_button.h"
#include "chrome/browser/ui/views/location_bar/page_action_image_view.h"
#include "chrome/browser/ui/views/location_bar/star_view.h"
+#include "chrome/browser/ui/views/location_bar/translate_icon_view.h"
#include "chrome/browser/ui/views/outdated_upgrade_bubble_view.h"
#include "chrome/browser/ui/views/wrench_menu.h"
#include "chrome/browser/ui/views/wrench_toolbar_button.h"
@@ -283,6 +284,12 @@ views::View* ToolbarView::GetBookmarkBubbleAnchor() {
return app_menu_;
}
+views::View* ToolbarView::GetTranslateBubbleAnchor() {
+ views::View* translate_icon_view = location_bar()->translate_icon_view();
+ DCHECK(translate_icon_view);
Takashi Toyoshima 2013/10/08 14:54:09 Did you check if this DCHECK is correct?
hajimehoshi 2013/10/10 11:07:10 Ah, this could be called before LocationBarView's
+ return translate_icon_view;
+}
+
views::MenuButton* ToolbarView::app_menu() const {
return app_menu_;
}

Powered by Google App Engine
This is Rietveld 408576698